Implement Scheduling Optimizations and Enhance Dependency Resolution and Benchmarking Mechanisms#59
Merged
gliargovas merged 78 commits intofuturefrom Sep 26, 2023
Merged
Conversation
Collaborator
Author
|
I manually ran the tests, and everything passed (the error was in comment on PR) - with or without sandbox killing |
Add link to optimization issues
angelhof
approved these changes
Sep 25, 2023
Member
angelhof
left a comment
There was a problem hiding this comment.
Please change the title and description to reflect the actual scope of this PR.
Feel free to merge without additional approval after you resolve my comments :)
| if len(predecessor) == 0: | ||
| return None | ||
| else: | ||
| most_recent_env_node = predecessor[0] |
Member
There was a problem hiding this comment.
Add a comment here that this won't work if we move to a full partial order, ideally together with an assertion that len(predecessor) <=1 so that it fails once we move to a proper full partial order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this extensive pull request, major improvements and refinements have been carried out (beyond the initial focus on benchmarks and reporting).
Dependency Resolution
Benchmarking Enhancements
Scheduler Optimizations
Miscellaneous Refinements:
Code and Documentation Quality: