Conversation
|
OS:ubuntu-24.04 |
Member
|
Thanks a lot! Could you sign the commits off for the DCO to pass? Here are the instructions: To add your Signed-off-by line to every commit in this branch:
Once you do that we will merge! |
Signed-off-by: Victor Canard-Duchêne <vcanard@Victors-MacBook-Air.local>
Signed-off-by: Victor Canard-Duchêne <vcanard@Victors-MacBook-Air.local>
2ac7cb4 to
73d32cf
Compare
|
OS:ubuntu-24.04 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Ubuntu 22.04.5, running distro_deps and then setup_pash fails as it is missing libtool as a dep.
I added it to the distro deps script as a pkg dep for all distros, but have only tested it for Ubuntu.
The other distros should behave the same as libtool is a GNU dep called by libdash.