Merged
Conversation
[ci skip]
…heduling https://community.openproject.org/wp/68357 When a work package in automatic scheduling mode has children, its `ignore_non_working_days` value is set by the children's values: - if at least one child has `ignore_non_working_days` `true`, then the parent has it `true`. - if all children have `ignore_non_working_days` `false`, then the parent has it `false`.
failing spec: ./spec/features/work_packages/details/date_editor_spec.rb:481 failing run: https://github.com/opf/openproject/actions/runs/18496811091/job/52702962599 When the working days only checkbox is toggled, the preview is triggered and updates the datepicker modal. There was a race condition: if switching to automatic scheduling mode before the preview finished, the preview would update the datepicker modal and switching to automatic would be ignored (maybe it should not be ignored). This was causing the spec to fail because the "working days only" checkbox was not disabled. Fix is to wait for the preview to finish before switching to automatic scheduling mode.
Moved turbo stream scroll preservation from individual lazy-page controllers to a single handler at the index controller level. This eliminates O(n) event handler overhead where n = number of lazy pages.
Since we set up UI skeletons, the scroll preservation is no longer needed.
This is related to https://community.openproject.org/wp/68047. The FrozenError bug has been fixed upstream and our patch is now useless.
Upgrade plaintext gem from 0.3.4 to 0.3.6
* Split workflow tables into multiple tabs Co-authored-by: Behrokh Satarnejad <b.satarnejad@openproject.com> * make header and first column sticky in work flow tables * calculate the height of the table * Update the tabs individually * calculate the height of the table * Add tests for separated Workflow update process * add a new style sheet for the workflows page and handle vertical and horizontal scroll in it * set a class for page header in workflows page * set page header class for other pages like summary and copy as well * make header and first column sticky in summary page * make the button sticky while scrolling horizontally * redirect to the current tab in update method --------- Co-authored-by: Behrokh Satarnejad <b.satarnejad@openproject.com>
…omatic-mode-working-days-only-is-not-set-correctly [68357] Derive ignore_non_working_days when switching to automatic scheduling
Bug/66552: Fine tune work package activity tab lazy page loading
Merge release/16.5 into dev
…ing-changes Update blocknote version
…es never load, only the first page is loaded (#20660) https://community.openproject.org/work_packages/68404 When the root (scrollableContainer) is undefined, fall back to the document viewport. Do not return early or abort the observer setup. > [!NOTE] > Specifying the root is generally a good idea for scoping down the observable area. When the root is null, Stimulus-Use will fallback to the document viewport. 📖 https://stimulus-use.github.io/stimulus-use/#/use-intersection?id=reference > > The "root" is different based on the context the activity tab is rendered- we maintain [a list of variants](https://github.com/opf/openproject/blob/dev/frontend/src/stimulus/controllers/dynamic/work-packages/activities-tab/services/view-port-service.ts#L85-L96), but I don't particularly like adding to that list. Rather falling back.
…a-item Highlight meeting agenda item on page load
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )