Add shortcut parameter to gui_register_ctx_menu#193
Merged
Conversation
Lets plugins specify a Qt-style keyboard shortcut (e.g. "Ctrl+Shift+D")
when registering a context menu / plugin action. Each decompiler
backend translates the shortcut to its native form:
- IDA: passed as the 4th arg of `idaapi.action_desc_t` ("Ctrl-Shift-D")
- Binja: registered via `UIAction.registerAction` + `UIActionHandler.bindAction`
- Ghidra: `ActionBuilder.keyBinding("ctrl shift D")`
- angr: `QShortcut` on the workspace main window with `ApplicationShortcut`
context, kept in `GenericBSAngrManagementPlugin._qshortcuts` to avoid
garbage collection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets plugins specify a Qt-style keyboard shortcut (e.g. "Ctrl+Shift+D") when registering a context menu / plugin action. Each decompiler backend translates the shortcut to its native form:
idaapi.action_desc_t("Ctrl-Shift-D")UIAction.registerAction+UIActionHandler.bindActionActionBuilder.keyBinding("ctrl shift D")QShortcuton the workspace main window withApplicationShortcutcontext, kept inGenericBSAngrManagementPlugin._qshortcutsto avoid garbage collection