Skip to content

Conversation

@hejung
Copy link
Collaborator

@hejung hejung commented Feb 24, 2025

Add the option to pass sbatch options to the SlurmProcess and makes use of the new sbatch_options argument to the SlurmProcess in:

  • SlurmGmxEngine
  • SlurmTrajectoryFunction

@codecov
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 73.43750% with 17 lines in your changes missing coverage. Please review.

Project coverage is 57.62%. Comparing base (fd81a88) to head (fdf0026).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
src/asyncmd/slurm.py 75.80% 15 Missing ⚠️
src/asyncmd/gromacs/mdengine.py 0.00% 1 Missing ⚠️
src/asyncmd/trajectory/functionwrapper.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   57.24%   57.62%   +0.37%     
==========================================
  Files          18       18              
  Lines        2318     2362      +44     
  Branches      317      324       +7     
==========================================
+ Hits         1327     1361      +34     
- Misses        914      924      +10     
  Partials       77       77              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hejung hejung merged commit e72d496 into bio-phys:main Apr 1, 2025
6 checks passed
@hejung hejung deleted the sbatch_options branch April 1, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant