Add default root collection#231
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a synthesized default root collection so the site has a usable root listing even when no top-level index.md(x)/collection.md(x) file is present. parseCollection now falls back to a built-in # Notes content string for the root path, and updateRoot no longer guards on the existence of a root markdown file. A non-root collection without an index file still throws.
Changes:
parseCollectionfalls back to aDefaultCollectionContent(# Notes) when no index file exists at the root, and otherwise throws for non-root paths.updateRootunconditionally callsparseCollection([], [])instead of conditionally constructing the root collection.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| ingest/collection.ts | Adds a default root content fallback and explicit error for missing index in non-root collections. |
| ingest/updatePaths.ts | Always parses the root collection, relying on the new fallback behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0eed5f7 to
be7b1c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.