[FIX] Remove '(from Orange3)' from widget names in canvas#1385
Merged
astaric merged 1 commit intobiolab:masterfrom Jul 6, 2016
Merged
[FIX] Remove '(from Orange3)' from widget names in canvas#1385astaric merged 1 commit intobiolab:masterfrom
astaric merged 1 commit intobiolab:masterfrom
Conversation
Current coverage is 88.04%@@ master #1385 diff @@
==========================================
Files 77 77
Lines 7489 7489
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 6594 6594
Misses 895 895
Partials 0 0
|
Contributor
|
setup.py doesn't get installed. You could check for existence of '-': desc.project_name and (not desc.project_name.startswith('Orange') or '-' in desc.project_name) |
Contributor
Author
|
Why |
Contributor
|
So the addendum won't show for Orange core widgets but will show for widgets from add-ons, normally named Orange-Something. It's what the PR is about, no? |
Contributor
Author
|
Changed as told. And let's please attribute my question to sleep deprivation or something. Thanks. |
Orange/canvas/registry/qt.py
Outdated
| tooltip.append("<b>{name}</b>".format(name=escape(desc.name))) | ||
|
|
||
| if desc.project_name and desc.project_name != "Orange": | ||
| if desc.project_name and (not desc.project_name.startswith('Orange') or |
Member
There was a problem hiding this comment.
We could also remove the additional condition and just show (from package_name) for all projects. This might come in handy if (when) we decide to separate canvas and core widgets.
Contributor
Author
|
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tooltips on widget toolbars showed "(from Orange3)" after the name of each widget due to mismatching project name.
@ales-erjavec, @astaric, is there a better, long-term solution? Comparing with
Orange.setup.NAMEdoesn't seem appropriate - or is it?