Skip to content

[FIX] Test & Score: Instantly recognize new input#2219

Closed
jerneju wants to merge 1 commit into
biolab:masterfrom
jerneju:gh-1842-test-score
Closed

[FIX] Test & Score: Instantly recognize new input#2219
jerneju wants to merge 1 commit into
biolab:masterfrom
jerneju:gh-1842-test-score

Conversation

@jerneju
Copy link
Copy Markdown
Contributor

@jerneju jerneju commented Apr 11, 2017

Issue

#1842

Description of changes
Includes
  • Code changes
  • Tests
  • Documentation

@jerneju jerneju requested a review from ajdapretnar April 11, 2017 09:44
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2219 into master will increase coverage by 0.99%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2219      +/-   ##
==========================================
+ Coverage   71.18%   72.17%   +0.99%     
==========================================
  Files         318      318              
  Lines       54765    54765              
==========================================
+ Hits        38983    39526     +543     
+ Misses      15782    15239     -543

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3690174...461b142. Read the comment docs.

@janezd
Copy link
Copy Markdown
Contributor

janezd commented Apr 13, 2017

This will call _invalidate twice - first from set_train_data and then from handleNewSignals. As a consequence, cross-validation (or whatever testing) is run twice for each change of train or test data.

Connect Random forest to Test and Score and set it to induce 100 trees. Then feed brown-selected data to Test and Score and observe what happens.

@janezd janezd closed this Apr 13, 2017
@jerneju
Copy link
Copy Markdown
Contributor Author

jerneju commented Apr 14, 2017

Well I see. I changed the code, may I reopen or open new PR?

@janezd
Copy link
Copy Markdown
Contributor

janezd commented Apr 15, 2017

As you like. I closed it since it was just a single line, so opening a new PR is as costly as keeping this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants