io, OWFile: if URL without scheme, assume http by default#2393
Merged
astaric merged 3 commits intobiolab:masterfrom Sep 1, 2017
Merged
io, OWFile: if URL without scheme, assume http by default#2393astaric merged 3 commits intobiolab:masterfrom
astaric merged 3 commits intobiolab:masterfrom
Conversation
Contributor
|
|
Contributor
Author
|
|
Contributor
|
Tests fail. Please fix. Test with more urls. Why lstrip? |
Codecov Report
@@ Coverage Diff @@
## master #2393 +/- ##
==========================================
- Coverage 75.33% 75.05% -0.29%
==========================================
Files 327 327
Lines 57595 57625 +30
==========================================
- Hits 43388 43249 -139
- Misses 14207 14376 +169 |
kernc
force-pushed
the
from_url
branch
5 times, most recently
from
1b53592 to
c39c24a
Compare
Contributor
Author
I don't know why the test fails. Please help.
What other URLs are reasonable to test with? |
astaric
force-pushed
the
from_url
branch
2 times, most recently
from
f8e667f to
293f6d2
Compare
Member
|
The failing test on python3.4 was caused by a call to a method that has been added in Qt5. After replacing the call the test passes (locally), let's see what happens on travis. |
The latter is only available in Qt5.
FileWidget catches all exceptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
#2388
Includes