[ENH] Save widgets: Store paths relative to workflow directory#4532
Merged
PrimozGodec merged 1 commit intobiolab:masterfrom Mar 20, 2020
Merged
[ENH] Save widgets: Store paths relative to workflow directory#4532PrimozGodec merged 1 commit intobiolab:masterfrom
PrimozGodec merged 1 commit intobiolab:masterfrom
Conversation
cfea969 to
b26a327
Compare
Codecov Report
@@ Coverage Diff @@
## master #4532 +/- ##
==========================================
+ Coverage 83.38% 83.46% +0.08%
==========================================
Files 279 276 -3
Lines 55780 55267 -513
==========================================
- Hits 46510 46130 -380
+ Misses 9270 9137 -133 |
Contributor
|
The implementation works correctly. There is only one thing I would change. When setting a location to save data the text at the save button changes to |
b26a327 to
c35adf0
Compare
Contributor
|
Thank you. It is great now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes part of #4464 by storing paths relative to the workflow directory.
Description of changes
Path is always relative to the workflow directory, and the saved file must be either in the same director or in its subtree. On loading the widget, auto-save is disabled unless a relative path is used to prevent auto saving to arbitrary locations when the workflow is loaded.
Implementation does not use
RecentPathbecause it does not fit.All core widgets for saving (Save, Save Distances, Save Model) are derived from this base class, so the patch should work for them, as well as for all properly written widgets in add-ons (Save Network).
I took care to keep the backward compatibility, though ... please check all potentially affected add-ons.
Unlike codecov, I believe that coverage is 100 %. At least judging by codecov's diff.
Includes