[ENH] Projections keep colors after merging values#4577
Merged
robertcv merged 1 commit intobiolab:masterfrom Apr 3, 2020
Merged
[ENH] Projections keep colors after merging values#4577robertcv merged 1 commit intobiolab:masterfrom
robertcv merged 1 commit intobiolab:masterfrom
Conversation
aca0d30 to
7d1fc82
Compare
Codecov Report
@@ Coverage Diff @@
## master #4577 +/- ##
==========================================
+ Coverage 83.60% 83.62% +0.02%
==========================================
Files 276 276
Lines 55372 55455 +83
==========================================
+ Hits 46292 46375 +83
Misses 9080 9080 |
7d1fc82 to
c20f1b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #4515.
I don't like it because if a variable has 100 values, which are merged into 15, they will not use a better palette for 15 colors, but instead have a HSL-based palette with 15 hues out of 100. This rather defeats the purpose of merging.No longer important after we implement #4581.To do:
Improve implementation if possible. RethinkWe decided, upon @VesnaT's encouragement, that the code may not be optimal, but it is more maintainable the way it is. Callingget_columnwhich was called twice for colors and shapes, and would now be called thrice for colors.get_column_viewmultiple times shouldn't affect the performance because it is linear w.r.t. the number of rows.Description of changes
Includes