Skip to content

[FIX] OWScatterPlotBase: Reset view before labels update#4907

Merged
janezd merged 2 commits into
biolab:masterfrom
VesnaT:reset_view_proj
Jul 31, 2020
Merged

[FIX] OWScatterPlotBase: Reset view before labels update#4907
janezd merged 2 commits into
biolab:masterfrom
VesnaT:reset_view_proj

Conversation

@VesnaT
Copy link
Copy Markdown
Contributor

@VesnaT VesnaT commented Jul 17, 2020

Issue

In some cases labels on projection widgets are deficiently shown.
To reproduce:

  1. File (brown-selected) -> Preprocess -> MDS
  2. MDS: Set Label to Genes
  3. Preprocess (Select Normalize Features)
  4. MDS: All labels are show
  5. Preprocess (Remove normalizer)
  6. MDS: Some labels (close to left and upper edge) are missing
Description of changes

Reset view before updating the labels.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 31, 2020

Codecov Report

Merging #4907 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           master    #4907    +/-   ##
========================================
  Coverage   84.12%   84.13%            
========================================
  Files         283      278     -5     
  Lines       57819    57007   -812     
========================================
- Hits        48643    47961   -682     
+ Misses       9176     9046   -130     

@janezd janezd merged commit 6193d32 into biolab:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants