Skip to content

[FIX] Save File when workflow basedir is an empty string#5459

Merged
janezd merged 2 commits intobiolab:masterfrom
ales-erjavec:fixes/runner-basedir-absolute-path
Jun 4, 2021
Merged

[FIX] Save File when workflow basedir is an empty string#5459
janezd merged 2 commits intobiolab:masterfrom
ales-erjavec:fixes/runner-basedir-absolute-path

Conversation

@ales-erjavec
Copy link
Contributor

Issue

workflow.ows.zip

python -m Orange.canvas.run workflow.ows

Does not save the results.tab file while

python -m Orange.canvas.run ./workflow.ows

does

Similarly running orange-canvas workflow.ows resets the Save Data's auto_save setting (this one needs similar fix in orange-canvas-core)

Description of changes
  • Always use absolute path for workflow base dir.
  • Fix check for workflow base dir in OWSaveBase.
Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #5459 (46e2a98) into master (54f3e0e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5459   +/-   ##
=======================================
  Coverage   86.35%   86.35%           
=======================================
  Files         304      304           
  Lines       61652    61652           
=======================================
+ Hits        53240    53241    +1     
+ Misses       8412     8411    -1     

@janezd janezd merged commit 9651f85 into biolab:master Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants