fix: allow overriding rule group by each rule#5459
Merged
siketyan merged 2 commits intobiomejs:mainfrom Mar 26, 2025
Merged
Conversation
siketyan
commented
Mar 25, 2025
Comment on lines
753
to
769
| *self = match (&self, other) { | ||
| (Self::Plain(lhs), Self::Plain(rhs)) => { | ||
| let mut lhs = lhs.clone(); | ||
| lhs.merge_with(rhs); | ||
| Self::Plain(lhs) | ||
| } | ||
| (Self::Group(lhs), Self::Group(rhs)) => { | ||
| let mut lhs = lhs.clone(); | ||
| lhs.merge_with(rhs); | ||
| Self::Group(lhs) | ||
| } | ||
| (Self::Plain(lhs), Self::Group(rhs)) => { | ||
| let mut lhs = G::from(*lhs); | ||
| lhs.merge_with(rhs); | ||
| Self::Group(lhs) | ||
| } | ||
| (Self::Group(_), Self::Plain(rhs)) => Self::Plain(rhs), |
Member
Author
There was a problem hiding this comment.
This is ugly, but there is a moved value issue :(
ematipico
approved these changes
Mar 26, 2025
Member
ematipico
left a comment
ematipico
left a comment
There was a problem hiding this comment.
Looks good! Just some linting to fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed #5456
Previously, merging a rule configuration into a rule group configuration was not supported.
Added a merge implementation as expanding the group and merge specific rules.
Test Plan
Test added.