Conversation
ematipico
reviewed
Mar 26, 2025
siketyan
force-pushed
the
ci/fix-js-api-publish
branch
2 times, most recently
from
238b454 to
73d9b4d
Compare
ematipico
approved these changes
Mar 26, 2025
Member
ematipico
left a comment
ematipico
left a comment
There was a problem hiding this comment.
Awesome, thank you for fixing this! 🙇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up of #5448
There was an unnecessary
ifcondition on the step and@biomejs/js-apiwas not published correctly. Removed the condition.Plus, I added a workflow_dispatch input to specify what version to publish.
Test Plan
N/A