feat(service): sort diagnostics by severity in descending order #5534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
To whom it may concern: I'm rusty with Rust. Please refactor as you see fit! |
ematipico
reviewed
Apr 1, 2025
Member
ematipico
left a comment
ematipico
left a comment
There was a problem hiding this comment.
Thank you for the contribution.
There's one more place where diagnostics are collected. It's in the CLI: https://github.com/biomejs/biome/blob/main/crates%2Fbiome_cli%2Fsrc%2Fexecute%2Ftraverse.rs#L140-L154
Member
|
Also, remember to add a changeset too. It's explained in the contribution guide |
Member
|
@karpawich any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If Biome is to enforce a limit on the number of diagnostics shown to the user, then it ought to sort them so as to show the most severe diagnostics first.
See Discussion#5180
Test Plan
I implemented a simple test of the sorting logic in
scanner.tests.ts