Add top-level descriptions response field#20
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a top-level descriptions field to normalized node responses (when description=true) that aggregates all non-empty descriptions across equivalent identifiers, matching NodeNorm Redis behavior (issue #12).
Changes:
- Replace the single-description extraction in
create_normalized_nodewith a flattened, deduplicated list of all non-empty descriptions and expose it asdescriptionswhile keeping the first one asid.description. - Change the default of
include_descriptionsfromTruetoFalseincreate_normalized_node(the only caller passes it explicitly). - Add pytest cases covering both the descriptions-enabled aggregation and the default-off behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/nodenorm/handlers/normalized_nodes.py | Aggregates and deduplicates descriptions, adds top-level descriptions key, flips default of include_descriptions to False. |
| tests/test_normalized_nodes_lookup.py | Adds tests verifying description aggregation and default suppression. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solve #12