Skip to content

import our SDK modifications#1

Open
KanjiMonster wants to merge 29 commits intobisdn/mainfrom
jogo_bisdn_patches
Open

import our SDK modifications#1
KanjiMonster wants to merge 29 commits intobisdn/mainfrom
jogo_bisdn_patches

Conversation

@KanjiMonster
Copy link
Copy Markdown
Collaborator

@KanjiMonster KanjiMonster commented Apr 27, 2026 •
edited
Loading

Import our SDK modifications as commits. This will be used in the future instead of patchsets for our recipes. This does not include changes we inherited from OF-DPA, as these are "proprietary".

Mostly identical to the existing patches except for some minor white space and style fixes:

diff --git a/sdk-6.5.24/include/kcom.h b/sdk-6.5.24/include/kcom.h
index 9495b2168b7e..50bfd22322cc 100755
--- a/sdk-6.5.24/include/kcom.h
+++ b/sdk-6.5.24/include/kcom.h
@@ -50,7 +50,7 @@
 
 #define KCOM_VERSION            13 /* Protocol version */
 
-#define KCOM_M_NETIF_STATS	128 /* Netif stats */
+#define KCOM_M_NETIF_STATS      128 /* Netif stats */
 #define KCOM_M_NETIF_STATE      129 /* Netif link state */
 
 /*
diff --git a/sdk-6.5.24/src/bcm/esw/knet.c b/sdk-6.5.24/src/bcm/esw/knet.c
index e670d4509833..0a295da69706 100644
--- a/sdk-6.5.24/src/bcm/esw/knet.c
+++ b/sdk-6.5.24/src/bcm/esw/knet.c
@@ -267,46 +267,45 @@ _trav_filter_clean(int unit, bcm_knet_filter_t *filter, void *user_data)
 STATIC int
 _update_netif_stats(int unit, bcm_knet_netif_t *netif, void *user_data)
 {
-  kcom_msg_netif_stats_t stats_msg;
-  /* keep in sync with kcom_netif_stats_t */
-  bcm_stat_val_t stat_arr[] = {
-    snmpDot1dTpPortInFrames,
-    snmpDot1dTpPortOutFrames,
-    snmpIfInOctets,
-    snmpIfOutOctets,
-    snmpIfInErrors,
-    snmpIfOutErrors,
-    snmpIfInDiscards,
-    snmpIfOutDiscards,
-    snmpIfInMulticastPkts,
-    snmpEtherStatsCollisions,
-    snmpDot3StatsInRangeLengthError,
-    snmpDot3StatsFrameTooLongs,
-    snmpDot3StatsFCSErrors,
-    snmpDot3StatsAlignmentErrors,
-    snmpDot3StatsCarrierSenseErrors,
-    snmpDot3StatsSQETTestErrors,
-    snmpDot3StatsLateCollisions,
-  };
-
-  int rv;
-
-  if (netif->type != BCM_KNET_NETIF_T_TX_LOCAL_PORT)
-      return 0;
-
-  sal_memset(&stats_msg, 0, sizeof(stats_msg));
-  stats_msg.hdr.opcode = KCOM_M_NETIF_STATS;
-  stats_msg.hdr.unit = unit;
-  stats_msg.hdr.id = netif->id;
-
-  rv = bcm_esw_stat_multi_get(unit, netif->port, COUNTOF(stat_arr), stat_arr,
-                              (uint64 *)&stats_msg.netif_stats);
-  if (BCM_SUCCESS(rv)) {
-    rv = soc_knet_cmd_req((kcom_msg_t *)&stats_msg, sizeof(stats_msg),
-                          sizeof(stats_msg));
-  }
-
-  return rv;
+    kcom_msg_netif_stats_t stats_msg;
+    /* keep in sync with kcom_netif_stats_t */
+    bcm_stat_val_t stat_arr[] = {
+        snmpDot1dTpPortInFrames,
+        snmpDot1dTpPortOutFrames,
+        snmpIfInOctets,
+        snmpIfOutOctets,
+        snmpIfInErrors,
+        snmpIfOutErrors,
+        snmpIfInDiscards,
+        snmpIfOutDiscards,
+        snmpIfInMulticastPkts,
+        snmpEtherStatsCollisions,
+        snmpDot3StatsInRangeLengthError,
+        snmpDot3StatsFrameTooLongs,
+        snmpDot3StatsFCSErrors,
+        snmpDot3StatsAlignmentErrors,
+        snmpDot3StatsCarrierSenseErrors,
+        snmpDot3StatsSQETTestErrors,
+        snmpDot3StatsLateCollisions,
+    };
+    int rv;
+
+    if (netif->type != BCM_KNET_NETIF_T_TX_LOCAL_PORT)
+        return 0;
+
+    sal_memset(&stats_msg, 0, sizeof(stats_msg));
+    stats_msg.hdr.opcode = KCOM_M_NETIF_STATS;
+    stats_msg.hdr.unit = unit;
+    stats_msg.hdr.id = netif->id;
+
+    rv = bcm_esw_stat_multi_get(unit, netif->port, COUNTOF(stat_arr), stat_arr,
+                                (uint64 *)&stats_msg.netif_stats);
+    if (BCM_SUCCESS(rv)) {
+        rv = soc_knet_cmd_req((kcom_msg_t *)&stats_msg, sizeof(stats_msg),
+                              sizeof(stats_msg));
+    }
+
+    return rv;
 }
 
 STATIC void
@@ -317,11 +316,11 @@ _update_all_netif_stats(int unit)
 
 typedef struct _knet_stats_ctrl_s
 {
-  char taskname[16];
-  sal_sem_t sema;
-  int running;
-  int stop;
-  int unit;
+    char taskname[16];
+    sal_sem_t sema;
+    int running;
+    int stop;
+    int unit;
 } _knet_stats_ctrl_t;
 
 STATIC _knet_stats_ctrl_t _bcm_esw_knet_stats_ctrl[BCM_MAX_NUM_UNITS];
@@ -347,25 +346,24 @@ _bcm_esw_knet_stats_start(int unit)
     _knet_stats_ctrl_t *statc = KNET_STATS_CTRL(unit);
 
     statc->unit = unit;
-    if (statc->running) {
-    } else {
-      if (statc->sema == NULL) {
-        statc->sema = sal_sem_create("knet_stats_SLEEP", sal_sem_BINARY, 0);
-	if (statc->sema == NULL) {
-	  return BCM_E_MEMORY;
-	}
-      }
-
-      sal_snprintf(statc->taskname, sizeof(statc->taskname),
-		   "bcmKnetStats.%d", unit);
-      statc->stop = 0;
-      if (sal_thread_create(statc->taskname, SAL_THREAD_STKSZ, 50,
-			    _bcm_esw_netif_stats_thread, statc) == SAL_THREAD_ERROR) {
-        LOG_VERBOSE(BSL_LS_SOC_COMMON,
-                    (BSL_META_U(unit,
-                     "%s: Failed to start thread\n"), statc->taskname));
-        return BCM_E_MEMORY;
-      }
+    if (!statc->running) {
+        if (statc->sema == NULL) {
+            statc->sema = sal_sem_create("knet_stats_SLEEP", sal_sem_BINARY, 0);
+            if (statc->sema == NULL) {
+                return BCM_E_MEMORY;
+            }
+        }
+
+        sal_snprintf(statc->taskname, sizeof(statc->taskname),
+                     "bcmKnetStats.%d", unit);
+        statc->stop = 0;
+        if (sal_thread_create(statc->taskname, SAL_THREAD_STKSZ, 50,
+                              _bcm_esw_netif_stats_thread, statc) == SAL_THREAD_ERROR) {
+            LOG_VERBOSE(BSL_LS_SOC_COMMON,
+                        (BSL_META_U(unit,
+                         "%s: Failed to start thread\n"), statc->taskname));
+            return BCM_E_MEMORY;
+        }
     }
 
     return BCM_E_NONE;
diff --git a/sdk-6.5.24/systems/linux/kernel/modules/bcm-knet/bcm-knet.c b/sdk-6.5.24/systems/linux/kernel/modules/bcm-knet/bcm-knet.c
index 42fbf3908756..fc43346718e8 100755
--- a/sdk-6.5.24/systems/linux/kernel/modules/bcm-knet/bcm-knet.c
+++ b/sdk-6.5.24/systems/linux/kernel/modules/bcm-knet/bcm-knet.c
@@ -2250,11 +2250,11 @@ bkn_pkt_new_dscp(bkn_switch_info_t *sinfo, uint32_t *meta)
     case 34:
     case 35:
     case 37:
-	/* Triumph3 and newer */
+        /* Triumph3 and newer */
         dscp = (meta[11] & 0x1fu);
         break;
     case 36:
-	/* Trident 3 */
+        /* Trident 3 */
         dscp = ((meta[9] >> 5) & 0x1fu);
         break;
     default:
@@ -9741,7 +9741,7 @@ bkn_handle_cmd_req(kcom_msg_t *kmsg, int len)
         }
         break;
      case KCOM_M_NETIF_STATS:
-        DBG_CMD(("KCOM_M_WB_CLEANUP\n"));
+        DBG_CMD(("KCOM_M_NETIF_STATS\n"));
         /* Update netif hardware counters */
         len = bkn_knet_netif_stats(&kmsg->netif_stats, len);
         break;
diff --git a/sdk-6.5.27/src/bcm/esw/knet.c b/sdk-6.5.27/src/bcm/esw/knet.c
index 9fe3febb3dc6..35559850ef34 100644
--- a/sdk-6.5.27/src/bcm/esw/knet.c
+++ b/sdk-6.5.27/src/bcm/esw/knet.c
@@ -267,46 +267,45 @@ _trav_filter_clean(int unit, bcm_knet_filter_t *filter, void *user_data)
 STATIC int
 _update_netif_stats(int unit, bcm_knet_netif_t *netif, void *user_data)
 {
-  kcom_msg_netif_stats_t stats_msg;
-  /* keep in sync with kcom_netif_stats_t */
-  bcm_stat_val_t stat_arr[] = {
-    snmpDot1dTpPortInFrames,
-    snmpDot1dTpPortOutFrames,
-    snmpIfInOctets,
-    snmpIfOutOctets,
-    snmpIfInErrors,
-    snmpIfOutErrors,
-    snmpIfInDiscards,
-    snmpIfOutDiscards,
-    snmpIfInMulticastPkts,
-    snmpEtherStatsCollisions,
-    snmpDot3StatsInRangeLengthError,
-    snmpDot3StatsFrameTooLongs,
-    snmpDot3StatsFCSErrors,
-    snmpDot3StatsAlignmentErrors,
-    snmpDot3StatsCarrierSenseErrors,
-    snmpDot3StatsSQETTestErrors,
-    snmpDot3StatsLateCollisions,
-  };
-
-  int rv;
-
-  if (netif->type != BCM_KNET_NETIF_T_TX_LOCAL_PORT)
-      return 0;
-
-  sal_memset(&stats_msg, 0, sizeof(stats_msg));
-  stats_msg.hdr.opcode = KCOM_M_NETIF_STATS;
-  stats_msg.hdr.unit = unit;
-  stats_msg.hdr.id = netif->id;
-
-  rv = bcm_esw_stat_multi_get(unit, netif->port, COUNTOF(stat_arr), stat_arr,
-                              (uint64 *)&stats_msg.netif_stats);
-  if (BCM_SUCCESS(rv)) {
-    rv = soc_knet_cmd_req((kcom_msg_t *)&stats_msg, sizeof(stats_msg),
-                          sizeof(stats_msg));
-  }
-
-  return rv;
+    kcom_msg_netif_stats_t stats_msg;
+    /* keep in sync with kcom_netif_stats_t */
+    bcm_stat_val_t stat_arr[] = {
+        snmpDot1dTpPortInFrames,
+        snmpDot1dTpPortOutFrames,
+        snmpIfInOctets,
+        snmpIfOutOctets,
+        snmpIfInErrors,
+        snmpIfOutErrors,
+        snmpIfInDiscards,
+        snmpIfOutDiscards,
+        snmpIfInMulticastPkts,
+        snmpEtherStatsCollisions,
+        snmpDot3StatsInRangeLengthError,
+        snmpDot3StatsFrameTooLongs,
+        snmpDot3StatsFCSErrors,
+        snmpDot3StatsAlignmentErrors,
+        snmpDot3StatsCarrierSenseErrors,
+        snmpDot3StatsSQETTestErrors,
+        snmpDot3StatsLateCollisions,
+    };
+    int rv;
+
+    if (netif->type != BCM_KNET_NETIF_T_TX_LOCAL_PORT)
+        return 0;
+
+    sal_memset(&stats_msg, 0, sizeof(stats_msg));
+    stats_msg.hdr.opcode = KCOM_M_NETIF_STATS;
+    stats_msg.hdr.unit = unit;
+    stats_msg.hdr.id = netif->id;
+
+    rv = bcm_esw_stat_multi_get(unit, netif->port, COUNTOF(stat_arr), stat_arr,
+                                (uint64 *)&stats_msg.netif_stats);
+    if (BCM_SUCCESS(rv)) {
+        rv = soc_knet_cmd_req((kcom_msg_t *)&stats_msg, sizeof(stats_msg),
+                              sizeof(stats_msg));
+    }
+
+    return rv;
 }
 
 STATIC void
@@ -317,11 +316,11 @@ _update_all_netif_stats(int unit)
 
 typedef struct _knet_stats_ctrl_s
 {
-  char taskname[16];
-  sal_sem_t sema;
-  int running;
-  int stop;
-  int unit;
+    char taskname[16];
+    sal_sem_t sema;
+    int running;
+    int stop;
+    int unit;
 } _knet_stats_ctrl_t;
 
 STATIC _knet_stats_ctrl_t _bcm_esw_knet_stats_ctrl[BCM_MAX_NUM_UNITS];
@@ -347,25 +346,24 @@ _bcm_esw_knet_stats_start(int unit)
     _knet_stats_ctrl_t *statc = KNET_STATS_CTRL(unit);
 
     statc->unit = unit;
-    if (statc->running) {
-    } else {
-      if (statc->sema == NULL) {
-        statc->sema = sal_sem_create("knet_stats_SLEEP", sal_sem_BINARY, 0);
-	if (statc->sema == NULL) {
-	  return BCM_E_MEMORY;
-	}
-      }
-
-      sal_snprintf(statc->taskname, sizeof(statc->taskname),
-		   "bcmKnetStats.%d", unit);
-      statc->stop = 0;
-      if (sal_thread_create(statc->taskname, SAL_THREAD_STKSZ, 50,
-			    _bcm_esw_netif_stats_thread, statc) == SAL_THREAD_ERROR) {
-        LOG_VERBOSE(BSL_LS_SOC_COMMON,
-                    (BSL_META_U(unit,
-                     "%s: Failed to start thread\n"), statc->taskname));
-        return BCM_E_MEMORY;
-      }
+    if (!statc->running) {
+        if (statc->sema == NULL) {
+            statc->sema = sal_sem_create("knet_stats_SLEEP", sal_sem_BINARY, 0);
+            if (statc->sema == NULL) {
+                return BCM_E_MEMORY;
+            }
+        }
+
+        sal_snprintf(statc->taskname, sizeof(statc->taskname),
+                     "bcmKnetStats.%d", unit);
+        statc->stop = 0;
+        if (sal_thread_create(statc->taskname, SAL_THREAD_STKSZ, 50,
+                              _bcm_esw_netif_stats_thread, statc) == SAL_THREAD_ERROR) {
+            LOG_VERBOSE(BSL_LS_SOC_COMMON,
+                        (BSL_META_U(unit,
+                         "%s: Failed to start thread\n"), statc->taskname));
+            return BCM_E_MEMORY;
+        }
     }
 
     return BCM_E_NONE;
diff --git a/sdk-6.5.27/systems/linux/kernel/modules/bcm-knet/bcm-knet.c b/sdk-6.5.27/systems/linux/kernel/modules/bcm-knet/bcm-knet.c
index 1181d73823f4..7e717e4e42ed 100755
--- a/sdk-6.5.27/systems/linux/kernel/modules/bcm-knet/bcm-knet.c
+++ b/sdk-6.5.27/systems/linux/kernel/modules/bcm-knet/bcm-knet.c
@@ -2307,11 +2307,11 @@ bkn_pkt_new_dscp(bkn_switch_info_t *sinfo, uint32_t *meta)
     case 34:
     case 35:
     case 37:
-	/* Triumph3 and newer */
+        /* Triumph3 and newer */
         dscp = (meta[11] & 0x1fu);
         break;
     case 36:
-	/* Trident 3 */
+        /* Trident 3 */
         dscp = ((meta[9] >> 5) & 0x1fu);
         break;
     default:
@@ -9925,7 +9925,7 @@ bkn_handle_cmd_req(kcom_msg_t *kmsg, int len)
         len = bkn_knet_pcie_link_status_set(&kmsg->pcie_link_status, len);
         break;
      case KCOM_M_NETIF_STATS:
-        DBG_CMD(("KCOM_M_WB_CLEANUP\n"));
+        DBG_CMD(("KCOM_M_NETIF_STATS\n"));
         /* Update netif hardware counters */
         len = bkn_knet_netif_stats(&kmsg->netif_stats, len);
         break;

KanjiMonster and others added 29 commits April 14, 2026 15:06
@KanjiMonster
make: do not force a certain CC/CXX naming
ab5db2b 
Allow overriding CC/CXX to allow using ccache for faster recompilation.

Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
@ideaship @KanjiMonster
include/appl/diag/shell.h: new default log path
a5ef4b4 
The default log path, "bcm.log", results in the BCM log being written
to /usr/sbin/bcm.log. This commit moves the default path to the much
more appropriate /var/log/bcm.log.

Signed-off-by: Roger Luethi <roger.luethi@bisdn.de>
@KanjiMonster
diag: knetctrl: allow setting netif MAC addresses
c172d54 
Parse and pass a MACaddress to KNET when creating netinterfaces. Any
zero mac address will be ignored and only triggers a randomized MAC
address generation.

Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
@KanjiMonster
ledproc: add ag7648 led remap thread as option
dce7104 
Add support for the Delta AG7648 LED updater thread as a runtime option.

Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
@KanjiMonster
ag5648: ledproc_linkscan_cb correct LED bits
d37940d 
Add support for the Delta AG5648 LED values as a runtime option.

Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
@KanjiMonster
ledproc: add leddata support
4822ad4 
Add support for supplying a json encoded array of LED data values to
program based on link speed:

    [
     {
        "speed": 10,
        "value": "0x1"
     },
     {
        "speed": 100,
        "value": "0x3"
     },
     ...
    ]

So each object has two items, "speed" and "value", where speed is an
int, and value a string, containing a base 16 encoded LED value.

String was chosen as json lacks an unsigned int type, or other integer
representations than base 10.

Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
@KanjiMonster
kernel-modules: update proc code for linux 5.6+
799ed13 
Linux 5.6 switch proc from generic file_operations to proc_ops, so
update the code accordingly.

Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
@KanjiMonster
kernel-modules: add dropped defines to work with 5.9+
d4a799a 
With kernel 5.9 unlocked and compat ioctl is always on, so the defines
do not exist anymore, so define them ourselves for 5.9+.

Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
@KanjiMonster
linux-kernel-bde: update API usage for linux 5.10
5a79c1b 
Update linux-kernel-bde for 5.10:

- dma now always requires a device
- ioremap_nocache was dropped

Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
@KanjiMonster
bcm-knet: strip vlan tag if received untagged at port
72524b1 
The CPU port will always add a vlan tag, but we can check the header for
the state at reception. If it was received untagged, strip the vlan tag
to forward the packet as received to the kernel.

Different ASICs use different DCBs, which have the information stored at
different places. Add a function checking these, based on the documented
dcb types in OpenBCM/sdk-6.5.24/include/soc/shared/dcbformat/.

For now only support a subset of dcb types which we only care about.

Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
@KanjiMonster
bcm-knet: report link state
64a6f5b 
We set netif carrier, so we can just use ethtool_op_get_link.

Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
@KanjiMonster
bcm-knet: allow setting speed/duplex
349285c 
To allow better emulation of physical port devices, extend the link
state settings to also include link speed and duplex.

These are implemented as additional passable argument into proc link
entry, allowing multiple arguments as a comma separated list.

Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
@KanjiMonster
bcm-knet: implement get_link_ksettings
d249955 
To allow programs like ethtool access to the link speed, implement the
get_link_ksettings callback.

Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
@KanjiMonster
bcm-knet: only report speed/duplex on link
343f8a7 
If we have no link, the current speed/duplex is unknown.

Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
@KanjiMonster
bcm-knet: fix race between creation and open
9e90d7b 
When creating a netif, the netif will be registered and made available
to userspace before its private data is initialized.

This creates a window where accessing the device (e.g. opening it) may
cause a null pointer access since netdev_priv() isn't populated yet.

E.g. bkn_open will get priv->sinfo and access its fields:

  bkn_open(struct net_device *dev)
  {
      bkn_priv_t *priv = netdev_priv(dev);
      bkn_switch_info_t *sinfo = priv->sinfo;

But sinfo is only set *after* the netdev registration:

    if ((dev = bkn_init_ndev(ma, kmsg->netif.name)) == NULL) {
        kmsg->hdr.status = KCOM_E_RESOURCE;
        return sizeof(kcom_msg_hdr_t);
    }
    priv = netdev_priv(dev);
    priv->dev = dev;
    priv->sinfo = sinfo;

This can easily happen if a network manager like systemd-networkd tries
to configure and enable the network interface as soon as it is created.

Fix this by delaying register_netdev() until after the private data is
populated, with added code to undo any additional changes in case the
registration fails.

Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
@KanjiMonster
bcm-knet: use fully randomized mac addresses
35a9385 
Instead of using partially randomized mac addresses with a Broadcom OUI
prefix, use fully randomized mac addresses for generated virtualized
Ethernet devices.

To make sure the address is properly tagged as random, switch from
setting dev->dev_addr to using the helper functions
eth_hw_addr_{random,set}. Since these work on an existing device, we
need to move deciding whether to use a random mac into bkn_init_ndev.

Keep the Broadcom OUI prefixed MAC address for the base Ethernet device,
to make it more easily identifiable.

Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
@KanjiMonster
bcm-knet: allow marking packets as offloaded
e7f9188 
When using KNET interfaces in a bridge, Linux will flood or forward any
packets it sees according to default rules. This can be undesirable when
the packet was already flooded or forwarded by the switch itself, since
this will lead to the packets being duplicated.

To avoid this Linux supports marking packets as forwarding offloaded,
which prevents them from being forwarded in software, so add support for
marking packets as such.

Since this may break use cases where packets are redirected to the
controller, but are expected to be flooded/forwarded in software, make
this an optional flag per interface.

Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
@KanjiMonster
bcm-knet: replace open coded mac change code with eth_mac_addr
ba3a734 
Linux 5.17 made netdev->dev_addr[] constant, so we cannot modify it
anymore. Since bkn_set_mac_address() just directly sets the mac address,
we can replace it with the generic eth_mac_addr() implementation, and
set the IFF_LIVE_ADDR_CHANGE flag to allow MAC address changes while the
device is up, as before.

Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
@KanjiMonster
bcm-knet: update API for kernel 5.19
9512a7f 
Update kernel API usage for 5.18 and 5.19:

5.18 dropped pci_set_dma_mask(), which was just a wrapper for
dma_set_mask(), so just call dma_set_mask() directly.

5.19 dropped the weight argument from netif_napi_add() as most users
just passed the default value, and added a new call
netif_napi_add_weight() for passing a custom weight value.

Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
@KanjiMonster
linux-kernel-bde: use platform_get_irq()
8e2a689 
The Kernel stopped providing platform resources for IRQs of device tree
backed platform devices[1], and instead requires calling
platform_get_irq(), so do that. This also simplifies the code.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a1a2b7125e1079cfcc13a116aa3af3df2f9e002b

Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
@KanjiMonster
bcm-knet: extract and update DSCP for IP packets
283fece 
For currently unknown reasons the Broadcom ASIC does not update the DSCP
field for packets sent to controller. But the DMA header does have the
expected DSCP value. So use the DSCP value from the DMA header to update
IP(v6) packets if set.

Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
@KanjiMonster
bcm-knet: fix reported tx bytes
66ccfd2 
Do not include FCS and custom data header in tx byte counts. The custom
header is never transmitted on the wire and consumed by the ASIC, so we
should not count it, and we do not count it for rx bytes.

Likewise, rx and tx bytes should exclude the FCS, so we need to
substract it here as well.

Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
@KanjiMonster
bcm-knet: switch to stat64
20d85ad 
In preparation to report accurate counts, switch to stat64. This has no
effect on 64 bit, but for 32 bit this switches to 64 bit counters. Since
64 bit values cannot be written atomically, make use of u64_stat_sync
helpers.

Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
@KanjiMonster
KNET: push hardware counters to port netif
383ff9d 
Automatically push hw counters to netif interfaces whenever the cached
hw counters get updated.

To accomplish this, add a thread to the SDK that iterates over all
existing netifs and updates the counters if it's a port interface.

To not have to poll, register a extra counters callback that gets called
everytime the SDK counter thread collects counters, and triggers the
knet counter update thread.

Since the software counters are still interesting, delegate them to
IFLA_OFFLOAD_XSTATS_CPU_HIT type offload stats, which seem to be the
most appropriate.

For now only use a subset of counters to keep the size reasonable,
selected by matching the available counters [1] to rtnl_link_stats64
from the kernel [2].

[1] https://github.com/Broadcom-Network-Switching-Software/OpenBCM/blob/master/sdk-6.5.24/include/bcm/stat.h
[2] https://elixir.bootlin.com/linux/v6.6.90/source/include/uapi/linux/if_link.h#L42

Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
@KanjiMonster
bcm-knet: do not mark BPDU packets as offloaded
35efb20 
BPDU packets are trapped to controller and never forwarded, so do not
mark them as offloaded. This allows them to be forwarded/flooded in
software if needed.

Note that this requires configuring the switch ASIC to mark traffic as
BPDU via appropriate L2 cache entries, and there is no inherent
automatic classification.

Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
@KanjiMonster
linux-kernel-bde: handle renamed MAX_ORDER in linux 6.8+
9c7c32a 
MAX_ORDER was redefined and renamed as MAX_PAGE_ORDER in 6.8 with commit
23baf831a32c ("mm, treewide: redefine MAX_ORDER sanely").

Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
@KanjiMonster
bcm-knet: update API for kernel 6.11
3e63efd 
Update kernel API usage for kernel 6.11:

* strscpy() was dropped, with strlcpy() being mostly a drop-in
  replacement
* platform_driver::remove() now returns void instead of int
* ethtool_ts_info was renamed to kernel_ethtool_ts_info

Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
@KanjiMonster
KNET: add base support for tracked interfaces
699180b 
Add base support for tracked interfaces. Tracked interfaces fully
represent switch ports, with tracked configuration and state.

Since KNET allows multiple netifs for the same port, add a restriction
for tracked interfaces that they only may be one per port.

This also allows us storing a port -> netif lookup table.

Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
@KanjiMonster
KNET: update link state of tracked interfaces
9d4fa10 
Add a new message for SDK to send link state to KNET interfaces. For now
only support the basic attributes: link, speed, and duplex.

For ports created with the tracked, ignore any port state updates via
the old interface.

Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
@KanjiMonster KanjiMonster changed the title Jogo bisdn patches import our SDK modifications Apr 27, 2026
@KanjiMonster KanjiMonster marked this pull request as ready for review April 27, 2026 11:01
@KanjiMonster KanjiMonster requested a review from rubensfig April 27, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rubensfig rubensfig Awaiting requested review from rubensfig

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KanjiMonster @ideaship