[pull] master from dfinity:master#620
Merged
pull[bot] merged 44 commits intobit-cook:masterfrom Dec 13, 2022
Merged
Conversation
fix(ci): allow failure cargo build release Linux See merge request dfinity-lab/public/ic!9588
…'master' Correct dependency for check-bins-darwin. It should wait for `bazel-test-all-macos` which builds and uploads macos binaries. See merge request dfinity-lab/public/ic!9591
[MR-359] Staged rollout fix Fixes a potential underflow in a rollback scenario. -> Make sure that `QueueWithReservation::available_slots` can not underflow. While an underflow can currently not be triggered because of the invariants enforced on the queue, our upcoming changes regarding how reservations/slots in queues are handled may lead to such an underflow if the change is rolled out and then needs to be rolled back. See merge request dfinity-lab/public/ic!9590
fix: canister http fault tolerance rework Rework of old flaky canister http fault tolerance test. - Previously we used 3 nodes in which we are not fault-tolerant -> bump to 4 - Add deterministc transform to proxy canister because httpbin `/anything` returns a non-deterministic body. - Do continuous requests, which are all stored in proxy canister and in the end check if all of these requests returned status 200 - Create bazel system test target See merge request dfinity-lab/public/ic!9518
Use bytebuf, fix logging and better debug output The log output to stdout interfered with the communication of the testing binary with the actual test. See merge request dfinity-lab/public/ic!9584
…serializer-to-add-a-logging-layer' into 'master' feat(crypto): CRP-1835 wrap bincode serialiser/deserialiser to provide logging Wrap the serializer/deserializer (`Bincode`) used to transmit data between the remote CSP vault client and server over the RPC connection to provide additional logging and metrics regarding the size of the data being transmitted. This MR focusses on the ground infrastructure and logging part. A second MR will provide metrics. See merge request dfinity-lab/public/ic!9511
docs(consensus): Update get_highest_iter docs See merge request dfinity-lab/public/ic!9592
check conditions from Interface Spec for canister http_request calls This MR adjusts canister http_request checks according to [Interface Spec](https://ic-interface-spec.netlify.app/#ic-http_request). Specifically, it fixes the following checks: - "url - the requested URL. Its length must not exceed 8192." - "The size of an HTTP response from the remote server is the total number of bytes representing the names and values of HTTP headers and the HTTP body. The upper limit on the maximal size for the response is 2MB (2,000,000B) and this value also applies if no maximal size value is specified." - "The maximal number of bytes representing the response produced by the transform function is 2MB (2,000,000B). Note that the number of bytes representing the response produced by the transform function includes the serialization overhead of the encoding produced by the canister." - "The following additional limits apply to HTTP requests and HTTP responses from the remote sever: - the number of headers must not exceed 64, - the number of bytes representing a header name or value must not exceed 8KiB, and - the total number of bytes representing the header names and values must not exceed 48KiB." The checks will be tested by spec_compliance pre-master [test](dfinity/ic-hs#100) hooked in a follow-up MR. See merge request dfinity-lab/public/ic!9188
Set Bazel allowed to fail jobs to manual on merge requests See merge request dfinity-lab/public/ic!9599
fix: [MR-358] Disallow use of `Write::write()` Add a lint check to prevent accidental use of `Write::write()`, where `Write::write_all()` was intended. The check can be overridden locally, by adding an `#[allow(clippy::disallowed_methods)]` attribute where necessary. See merge request dfinity-lab/public/ic!9586
fix(FI-504) fix regex After a long fight between roman and chatgpt, it seems that we now have a winner :) See merge request dfinity-lab/public/ic!9598
[CRP-1833] crypto_service_provider_test is flaky See the Jira ticket for more information. See merge request dfinity-lab/public/ic!9478
fix: Remove the per field serialization attributes Looking at [serde documentation](https://serde.rs/container-attrs.html#default) it seems to be enough to have the global Default value defined. See merge request dfinity-lab/public/ic!9594
fix: Update NNS state deployment driver script See merge request dfinity-lab/public/ic!9585
fix(ckbtc): distribute change overdraft among outputs This change fixes a minor bug in ckBTC transaction composition algorithm. We increase the change if the change is lower than the dust threshold. However, we didn't subtract the extra change from the outputs. With this fix, we distribute the change "overdraft" among all outputs. See merge request dfinity-lab/public/ic!9605
chore(BOUN-550): Standardize responses from the ACL canister calls
Tested with:
```
ID ?= default
PRINCIPAL = $(shell dfx --identity "${ID}" identity get-principal)
CANISTER_NAME = certificate_orchestrator
ARGUMENT = ( \
record { \
rootPrincipals = vec { \
principal \"${PRINCIPAL}\"; \
} \
})
config:
echo ${ID} - ${PRINCIPAL}
deploy:
dfx deploy \
--mode reinstall --yes \
--argument "${ARGUMENT}" "${CANISTER_NAME}"
list:
$(eval @_CANISTER_ID := $(shell cat .dfx/local/canister_ids.json | jq -r .certificate_orchestrator.local))
dfx --identity "${ID}" canister call "${@_CANISTER_ID}" listAllowedPrincipals '()'
add_principal:
$(eval @_CANISTER_ID := $(shell cat .dfx/local/canister_ids.json | jq -r .certificate_orchestrator.local))
dfx --identity "${ID}" canister call "${@_CANISTER_ID}" addAllowedPrincipal "(principal \"${PRINCIPAL}\")"
rm_principal:
$(eval @_CANISTER_ID := $(shell cat .dfx/local/canister_ids.json | jq -r .certificate_orchestrator.local))
dfx --identity "${ID}" canister call "${@_CANISTER_ID}" rmAllowedPrincipal "(principal \"${PRINCIPAL}\")"
```
See merge request dfinity-lab/public/ic!9555
RUN-497: Upgrade wasmtime to version 3.0.1 Release notes: - https://github.com/bytecodealliance/wasmtime/blob/main/RELEASES.md#301 Changes: - bytecodealliance/wasmtime@release-1.0.0...release-3.0.0 The new version of Wasmtime has two breaking changes: - the signal handler stack size increased to 256KB, so we have to bump our stack size to that size. - error handling in has changed to work with `anyhow::Error` instead of `Trap`. See merge request dfinity-lab/public/ic!9573
fix(VER-2050): make malicious tests blocking on pre-master This MR removes the `allow_to_fail` tag from a number of system-test targets that do _not_ have an equivalent in `prod-test-driver.rs`. Affected targets: * replica_determinism_test * liveness_with_equivocation_test * request_auth_malicious_replica_test * tecdsa_complaint_test * safety_test * system_subnets_test * system_api_security_test See merge request dfinity-lab/public/ic!9611
Only copy images for aux nodes when needed Previously, we would try to copy aux node images on all hosts in a testnet, when we only pull images on those hosts that need it. This mismatch would cause some deployments to fail without a great error. See merge request dfinity-lab/public/ic!9613
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )