make -test fails on Arch

[graysky2]

It seems that common/configure wants py.test-3 but Arch does not provide that executable.

which: no py.test-3 in (/usr/local/sbin:/usr/local/bin:/usr/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl)

We have a package that provides: /usr/bin/py.test and /usr/bin/py.test-3.5

1. Can you modify common/configure to look for py.test-3.5 or py.test-3 or py.test in the PATH?

2. The make test still fails when I run it in the clean-chroot per the Arch build standards (but it does work outside in my live environment) Any ideas? Perhaps I am missing a dependency in the chroot that I have in the live environment? I do not know python so the error message is lost on me.

% make test
py.test-3.5 
test/test.sh
============================= test session starts ==============================
platform linux -- Python 3.5.1, pytest-2.8.5, py-1.4.31, pluggy-0.3.1
rootdir: /build/backintime/src/backintime-1.1.12/common, inifile: 
Clean testing directory
Create testing directory
Create testing data
collected 92 items

test/test_applicationinstance.py ..........
test/test_argparser.py ..............
================================================================================
 TEST --> A snapshot have been created 
 SUCCESS --> A snaphshot should have been created 
================================================================================

.......
test/test_configfile.py ................................................
test/test_snapshots.py ..
test/test_tools.py ...F.......

=================================== FAILURES ===================================
________________________ TestTools.test_process_exists _________________________

self = <test.test_tools.TestTools testMethod=test_process_exists>

    def test_process_exists(self):
        ''' Test the function process_exists '''
>       self.assertTrue(tools.process_exists("init") or tools.process_exists("systemd"))
E       AssertionError: False is not true

test/test_tools.py:68: AssertionError
===================== 1 failed, 91 passed in 3.37 seconds ======================
Makefile:561: recipe for target 'unittest' failed
make: *** [unittest] Error 1
make: *** Waiting for unfinished jobs....

================================================================================
 TEST --> No snapshot have been created 
 SUCCESS --> A useless snaphshot have been created 
================================================================================


================================================================================
 TEST --> A snaphshot should have been created 
 SUCCESS --> A snapshot have been created 
================================================================================


================================================================================
Summary integration tests :
--> Successes : 3 - Fails : 0
================================================================================

All tests passed successfully, cleaning testing directory

[Germar]

1. unittest should run without any extra dependencies. coverage is just used to protocol the usage of each line during tests and reports them to coveralls.io. It has no value outside of travis-ci.org (maybe I should really restrict this to travis...)
   py.test-3 just shows a fancy output which I prefer. But if non of both (coverage nor py.test-3) is available those tests will be run by python (or python3 depending on configure args).
2. The test in test-tools.py is failing because non of init nor systemd process where running. I thought at least one of these are default on every Linux 😕. Do you know a process which is constantly running on each and every Arch and even in chroot?

[Germar]

Oh, I just saw that for some reason it defaults to coverage instead of python. But I'm to tired to troubleshoot this today. Will fix it tomorrow.

[graysky2]

No problem. It's just the test function that fails; the package works fine. I am happy to test a commit when you are up to it.

[Germar]

Would you please give the current configure a try?

coverage and py.test-3.5 problems both should be fixed now.

To fix the 2nd problem would you please post a ps aux from inside the chroot?

[graysky2]

The new configure works great without either the 'python-coverage' or 'python-pytest' dependency.
Here is ps aux before the chroot runs make test

USER       PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND
root         1  0.0  0.0  14012  2752 ?        SNs+ 18:05   0:00 /bin/bash /chrootbuild
root         7  0.0  0.0  70368  4624 ?        SN+  18:05   0:00 sudo -u builduser makepkg -s --noconfirm -L --holdver
buildus+     8  0.0  0.0  13468  4236 ?        SN+  18:05   0:00 /usr/bin/bash /usr/bin/makepkg -s --noconfirm -L --holdver
buildus+   568  0.0  0.0   4208   828 ?        SN+  18:05   0:00 tee /logdest/backintime-1.1.12-1-x86_64-check.log

Thanks for the interest and keep up the great work with BIT ✊

[Germar]

Thanks for the ps. Pretty short proc list 😳

I'll have to use either the current process or spawn an extra process to test against.

[Germar]

2nd is fixed, too. Would you please clone master and run unittests on Arch and inside the chroot? I have no Arch at hand atm.