Code comments and PEP8 prettification.#1360
Merged
buhtz merged 7 commits intobit-team:masterfrom Nov 12, 2022
buhtz:enh/1354
Merged
Code comments and PEP8 prettification.#1360buhtz merged 7 commits intobit-team:masterfrom buhtz:enh/1354
buhtz merged 7 commits intobit-team:masterfrom
buhtz:enh/1354
Conversation
emtiu
reviewed
Nov 9, 2022
emtiu
reviewed
Nov 9, 2022
emtiu
reviewed
Nov 9, 2022
Member
|
Some minor suggestions, but looks good otherwise :) Out of curiosity: Is the manpage generation covered by testing somehow? Or does it only happen when we run the script manually? |
Co-authored-by: Michael Büker <emtiu@users.noreply.github.com>
Co-authored-by: Michael Büker <emtiu@users.noreply.github.com>
Co-authored-by: Michael Büker <emtiu@users.noreply.github.com>
Member
Author
No.
Only, when we run it manually. It is a "helper" script and conceptually don't belong to the release version of BIT. But looking into my Debian installation of BIT that py file is shipped with the release version. |
Member
Author
You mean this? I'll do it for you. ❤️ |
Contributor
|
Can we merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While investiagting the manpage creation script some comments where added. Also some code formatting was done to improve readability and better fitting PEP8 rules.
Also repaired special #? comments accidentially removed in PR #1313 before.
Related to #1354