fix: implement SSH clone with native interactive protocol#17
Merged
Conversation
SSH transport was failing because `build_upload_pack_remote_command` always added `--stateless-rpc` flags, which are rejected by SSH servers like GitHub. The fix has two parts: 1. Remove `--stateless-rpc` from the SSH remote command so it uses the native git interactive protocol. 2. Add pipe-based I/O for SSH fetch requests. File-based stdin doesn't work because SSH sends EOF immediately before the server processes wants. The new `run_ssh_upload_pack_interactive` function uses `spawn_orphan` with pipe stdin/stdout to properly sequence: read ref advertisement → write wants → close stdin → read pack. Fixes #13 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--stateless-rpcflags from SSH remote command (build_upload_pack_remote_command)run_ssh_upload_pack_interactive) usingspawn_orphanto properly sequence: read refs → write wants → read packTest plan
bit clone git@github.com:bit-vcs/bit-relay.git(SCP format)bit clone ssh://git@github.com/bit-vcs/bit-relay.git(SSH URL format)bit clone git@github.com:bit-vcs/bit.git(larger repo)--stateless-rpcin SSH commandsFixes #13
🤖 Generated with Claude Code