Move Blackboard initialization to export line#122
Closed
Werninator wants to merge 2 commits intobitbrain:godot-4.xfrom
Closed
Move Blackboard initialization to export line#122Werninator wants to merge 2 commits intobitbrain:godot-4.xfrom
Werninator wants to merge 2 commits intobitbrain:godot-4.xfrom
Conversation
If BeehaveTree is deactivated, the blackboard property will always be null. This is to allow editing a blackboard even if the tree is deactivated
Owner
|
Could you also add a test here? https://github.com/bitbrain/beehave/blob/godot-4.x/test/beehave_tree_test.gd |
bitbrain
added
the
🟡 changes requested
Author
|
I added a test to Closing this as making blackboard available even for disabled trees seems more a hustle to just leave it and wrap access to the blackboard with if-checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If BeehaveTree.enabled = false, the blackboard property will always be null if not otherwise assigned
This PR is there to allow editing a blackboard even if the tree is deactivated - reducing the need to add ifs outside the BeehaveTree itself. Also, correct me if I'm wrong - if the Tree starts out disabled, will it ever have a Blackboard (if not assigned)?