Added support to multiple subdomain based on bucket first level folders#2
Open
kesonno wants to merge 1 commit into
Open
Added support to multiple subdomain based on bucket first level folders#2kesonno wants to merge 1 commit into
kesonno wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@daaru00 come ti accennavo, questo branch ha dentro una modifica abbastanza significativa, quindi forse è più sano un fork con un repo dedicato, considerato che questo repo è abbastanza stabile quindi non mi aspetto grosse modifiche upstream che possa essere utile riportare in un eventuale fork. Paradossalmente, in questo branch c'è un piccolo fix che vorrei riportare riguardo l'invalidazione automatica (prima una modifica ad una index.html non invalidava il path della folder che la contiene).
Dai un'occhiata e dammi il tuo parere.