Fix: Thread Questions's slug (Chat & Bot)

[sheriffjimoh]

Summary by Sourcery

Refine URL building and parsing logic to correctly handle bot thread slugs and chat page prefixes, and clean up debug and lint code

Bug Fixes:

• Fix thread URL slug generation for bot threads by making domain and category optional, adding a 'b' base path, and trimming URL segments accordingly

Enhancements:

• Enhance path parsing to support chat pages prefixed with 'c' by stripping the prefix before routing

Chores:

• Add console.log for debugging thread pathParts and remove an obsolete lint-disable comment in the sidebar hook

Summary by CodeRabbit

• New Features
  • Introduced shorter, cleaner URLs for bot threads (no domain/category required), making sharing and navigation easier.
• Bug Fixes
  • Improved recognition and normalization of chat page URLs to ensure consistent routing.
• Chores
  • Removed redundant lint-ignore annotations in a sidebar hook to keep the codebase clean.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
masterbots	Ready	Preview	Comment	Sep 22, 2025 2:16pm
masterbots-pro	Error			Sep 22, 2025 2:16pm

[sourcery-ai]

Reviewer's Guide

This PR refactors the URL builder to correctly support 'bot' thread slugs by updating validation rules, basePath assignment, and path composition, adds debug logging for the threadQuestion builder, extends parsePath to handle chat pages, and removes an obsolete lint comment in the sidebar hook.

File-Level Changes

Change	Details	Files
Refactor thread URL builder to support bot type	Modify validation check to exempt category/domain when type is 'bot' Add 'bot' case mapping basePath to 'b' Splice out category and domain segments from pathParts for bot URLs	apps/web/lib/url.ts
Add debug logging in threadQuestion URL builder	Insert console.log to output pathParts for debugging threadQuestion URLs	apps/web/lib/url.ts
Implement chat page parsing in parsePath	Detect 'c' as chat page prefix and remove it before further parsing	apps/web/lib/url.ts
Remove redundant lint comment in sidebar hook	Delete unused biome-ignore lint/correctness comment above useMemo	apps/web/lib/hooks/use-sidebar.tsx

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[coderabbitai]

Walkthrough

Introduces a new 'bot' thread URL type with specialized construction and parsing in apps/web/lib/url.ts, adds chat-path normalization and debug logging, and removes two lint-ignore comments from apps/web/lib/hooks/use-sidebar.tsx. No public API signatures changed.

Changes

Cohort / File(s)	Summary
Sidebar hook lint cleanup apps/web/lib/hooks/use-sidebar.tsx	Removed two biome-ignore annotations around useMemo for filteredCategories; no behavioral changes.
URL construction and parsing updates apps/web/lib/url.ts	Added 'bot' thread URL type with base path 'b'; bot URLs omit domain/category segments. Adjusted validation to bypass domain/category for 'bot'. Enhanced path parsing to normalize chat (type 'c') paths. Inserted debug logging for constructed pathParts in threadQuestionUrl. No signature changes.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor UI as UI/Caller
  participant URL as url.ts
  participant Builder as ThreadURLBuilder
  participant Parser as PathParser
  participant Log as Debug Logger

  UI->>URL: buildThreadUrl(type, domain, category, ids)
  activate URL
  URL->>Builder: assemble pathParts
  alt type == "bot"
    note right of Builder: Omit domain/category segments
    Builder-->>URL: /b/{threadId}[/{questionId}]
  else non-bot
    Builder-->>URL: /t/{domain}/{category}/{threadId}[/{questionId}]
  end
  URL->>Log: debug(pathParts)
  URL-->>UI: full URL
  deactivate URL

  UI->>URL: parsePath(incomingPath)
  activate URL
  URL->>Parser: detect type/segments
  alt path is chat page (type "c")
    note right of Parser: Strip leading chat segment
  end
  Parser-->>URL: normalized parts
  URL-->>UI: Parsed result
  deactivate URL

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• chore: upt canonical domains #532: Also modifies route-type detection and URL normalization, including 'bot' handling.
• Feat: public continue thread #375: Adjusts URL construction used for "Continue Thread," impacted by new thread URL parsing/building.
• impr: browse sidebar #270: Touches the same use-sidebar hook with functional changes related to filteredCategories.

Suggested labels

bug, frontend

Suggested reviewers

• AndlerRL

Poem

A hop, a skip, a path made short—
Bots get lanes, a tidy sort.
Chats unmasked, their headers trimmed,
Logs now whisper where they’ve skimmed.
I twitch my ears at cleaner code,
Then bound along the URL road. 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "Fix: Thread Questions's slug (Chat & Bot)" accurately summarizes the primary change—fixing thread-question slugs for chat and bot URL types in url.ts—and therefore is closely related to the main changeset. It is concise and developer-focused, reflecting the URL construction and parsing updates while not attempting to enumerate minor edits. The removed lint-ignore comments in use-sidebar.tsx are incidental and do not reduce the title's relevance.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-new-popup-issues

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• Please remove the debug console.log in url.ts before merging.
• The splice-based adjustment of pathParts for the 'bot' type is brittle—consider building the segments conditionally rather than mutating the array after the fact for clearer logic.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Please remove the debug console.log in url.ts before merging.
- The splice-based adjustment of pathParts for the 'bot' type is brittle—consider building the segments conditionally rather than mutating the array after the fact for clearer logic.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (4)

apps/web/lib/url.ts (4)

280-284: Consider extracting 'bot' type validation to avoid repetition

The validation logic for the 'bot' type has been correctly implemented. However, similar logic appears in threadQuestionUrl (lines 363-366). Consider extracting this into a shared validation helper to maintain DRY principles.

Add a helper function at the top of the file (after line 136):

function validateBotUrlParams(params: { chatbot?: string; threadSlug?: string; threadQuestionSlug?: string }): boolean {
  return !!(params.chatbot && params.threadSlug)
}

Then refactor both functions to use it:

-if (
-  !chatbot ||
-  !threadSlug ||
-  (type !== 'bot' && (!domain || !category))
-) {
+if (type === 'bot' ? !validateBotUrlParams({ chatbot, threadSlug }) : (!chatbot || !threadSlug || !domain || !category)) {

---

328-330: Array manipulation logic is correct but could be clearer

The logic correctly removes category and domain segments for bot URLs by splicing out indices 2 and 3. However, this approach is fragile as it relies on positional knowledge after the initial push operation.

Consider building the path conditionally for better clarity:

-pathParts.push(
-  normalizeCategorySlug(category),
-  normalizeDomainSlug(domain, raw),
-  chatbot.toLowerCase(),
-  threadSlug,
-)
-
-if (type === 'bot') {
-  pathParts.splice(2, 2)
-}
+if (type === 'bot') {
+  pathParts.push(
+    chatbot.toLowerCase(),
+    threadSlug,
+  )
+} else {
+  pathParts.push(
+    normalizeCategorySlug(category),
+    normalizeDomainSlug(domain, raw),
+    chatbot.toLowerCase(),
+    threadSlug,
+  )
+}

---

428-432: Remove debug console.log before merging

Debug logging has been added but should be removed before merging to production.

-console.log({
-  'reach here for pathParts': {
-    pathParts,
-  },
-})

---

363-372: Bot type handling in threadQuestionUrl has inconsistent structure

The bot type handling here duplicates the slug construction logic and has an unnecessary check for !threadQuestionSlug after already confirming it exists.

Simplify the logic:

 if (type === 'bot') {
   if (!chatbot || !threadSlug || !threadQuestionSlug) {
     return '/'
   }
-  if (!threadQuestionSlug) {
-    return ['', 'b', toSlug(chatbot), threadSlug].join('/')
-  }
-  return ['', 'b', toSlug(chatbot), threadSlug, threadQuestionSlug].join(
+  return ['', 'b', chatbot.toLowerCase(), threadSlug, threadQuestionSlug].join(
     '/',
   )
 }

Also note that you're using toSlug(chatbot) here but chatbot.toLowerCase() elsewhere. For consistency, use chatbot.toLowerCase() throughout.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dc62926 and 240077a.

📒 Files selected for processing (2)

• apps/web/lib/hooks/use-sidebar.tsx (0 hunks)
• apps/web/lib/url.ts (5 hunks)

💤 Files with no reviewable changes (1)

• apps/web/lib/hooks/use-sidebar.tsx

🧰 Additional context used

📓 Path-based instructions (2)

**/*.{ts,tsx,js,jsx,cjs,mjs,json,jsonc}

📄 CodeRabbit inference engine (CLAUDE.md)

Use Biome for all formatting and linting (run bun format-and-lint:fix) instead of Prettier/ESLint

Files:

• apps/web/lib/url.ts

apps/{web,pro-web}/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

apps/{web,pro-web}/**/*.{ts,tsx}: Use feature detection before invoking modern Browser APIs
Implement progressive enhancement: basic functionality first, then enhancements
Add timing delays or requestAnimationFrame when the DOM needs to settle before operations
Verify DOM operations completed successfully; don’t assume success (e.g., scroll/check actual state)
Use multiple approaches for DOM actions: try modern APIs first, then fallback to legacy methods

Files:

• apps/web/lib/url.ts

🧠 Learnings (3)

📓 Common learnings

Learnt from: AndlerRL
PR: bitcashorg/masterbots#516
File: apps/masterbots.ai/lib/url.ts:592-615
Timestamp: 2025-06-25T20:11:57.360Z
Learning: Bot profiles use a different URL structure than user profiles. For bot profiles, the URL format is `/b/{chatbot}/{threadSlug}` and only requires chatbot, threadSlug, and optionally threadQuestionSlug parameters. Bot profiles should not use the user profile URL format (`/u/{usernameSlug}/t/{category}/{domain}/{chatbot}/{threadSlug}`) which requires usernameSlug, domain, and category parameters that are not available in bot profile contexts.

📚 Learning: 2025-06-25T20:11:57.360Z

Learnt from: AndlerRL
PR: bitcashorg/masterbots#516
File: apps/masterbots.ai/lib/url.ts:592-615
Timestamp: 2025-06-25T20:11:57.360Z
Learning: Bot profiles use a different URL structure than user profiles. For bot profiles, the URL format is `/b/{chatbot}/{threadSlug}` and only requires chatbot, threadSlug, and optionally threadQuestionSlug parameters. Bot profiles should not use the user profile URL format (`/u/{usernameSlug}/t/{category}/{domain}/{chatbot}/{threadSlug}`) which requires usernameSlug, domain, and category parameters that are not available in bot profile contexts.

Applied to files:

• apps/web/lib/url.ts

📚 Learning: 2024-11-28T07:10:40.413Z

Learnt from: AndlerRL
PR: bitcashorg/masterbots#313
File: apps/masterbots.ai/lib/hooks/use-sidebar.tsx:218-227
Timestamp: 2024-11-28T07:10:40.413Z
Learning: In the profile page `u/{username}/t`, when navigating between categories and chatbots, we should use shallow routing to enhance navigation performance.

Applied to files:

• apps/web/lib/url.ts

🔇 Additional comments (2)

apps/web/lib/url.ts (2)

309-311: LGTM! Bot URL type correctly added

The 'bot' case has been properly integrated into the switch statement, following the existing pattern and aligning with the bot profile URL structure mentioned in the retrieved learnings.

---

895-899: Chat page normalization correctly implemented

The logic properly handles chat page URLs by stripping the 'c' prefix, allowing the rest of the parsing logic to work correctly.

[AndlerRL]

LGTM! Nice fix, I see now why it was bugging the navigation 😬 it was ignoring the chat/bot pages route case—there was no such case to handle before.

Very good as usual, Jimoh 👍 Merging now!