This repository was archived by the owner on Apr 11, 2024. It is now read-only.
#25 - Review and refactor src/crypto/ecdsa.js.#56
Merged
ClemensLey merged 3 commits intobitcoin-computer:masterfrom Sep 14, 2018
Merged
#25 - Review and refactor src/crypto/ecdsa.js.#56ClemensLey merged 3 commits intobitcoin-computer:masterfrom
ClemensLey merged 3 commits intobitcoin-computer:masterfrom
Conversation
paranojik
changed the title
slashrsm
approved these changes
Sep 14, 2018
Contributor
slashrsm
left a comment
slashrsm
left a comment
There was a problem hiding this comment.
Made sure that:
- The tests are still passing
- Linter does not report any errors
Also read through the diff and all changes made sense. Ready to be merged as far as I am concerned. Thanks!
| return this; | ||
| } | ||
| } catch (e) { | ||
| console.error(e); // eslint-disable-line no-console |
Contributor
There was a problem hiding this comment.
We could probably use some better error handling approach? Not in scope for this issue in my opinion. Follow-up?
Contributor
There was a problem hiding this comment.
Agreed. As discussed, maybe we should add a pull request for removing console logs and fix them all together.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.