Display progress of LoadBlockDB() on splash screen#308
Closed
rebroad wants to merge 3 commits intobitcoin-core:masterfrom
Closed
Display progress of LoadBlockDB() on splash screen#308rebroad wants to merge 3 commits intobitcoin-core:masterfrom
rebroad wants to merge 3 commits intobitcoin-core:masterfrom
Conversation
rebroad
force-pushed
the
SplashLoadBlockProgress
branch
3 times, most recently
from
ece1e46 to
8924aa2
Compare
rebroad
force-pushed
the
SplashLoadBlockProgress
branch
from
8924aa2 to
34b954c
Compare
rebroad
force-pushed
the
SplashLoadBlockProgress
branch
from
34b954c to
05ec3cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some machines the splash screen can be displaying the message "Loading block index..." for quite a few minutes, causing some users to panic thinking the software has crashed or frozen.
This pull request makes it clear that the loading is progressing by showing a percentage that updates per second (although limited to no more updates than per 1 percent so as to reduce logging).
Is every 1 second too often? Maybe 5 or 10 seconds is better. Also, is this the correct repository or should it be a pull request in http://github.com/bitcoin/bitcoin ?