gui: Fix issues with new create wallet dialogue#934
Open
sbddesign wants to merge 2 commits intobitcoin-core:masterfrom
Open
gui: Fix issues with new create wallet dialogue#934sbddesign wants to merge 2 commits intobitcoin-core:masterfrom
sbddesign wants to merge 2 commits intobitcoin-core:masterfrom
Conversation
In the "Create Wallet" UI, there is an option and tooltip for "Encrypt Wallet", which is misleading because only the private key is encrypted. This updates the tooltip text to indicate that only the private key is encrypted. refs bitcoin-core#151
In the "Create Wallet" UI, checking the encrypt wallet option disables the "Disable Private Keys" option. However, checking the encryption option and "Make Blank Wallet" re-enables "Disable Private Keys" incorrectly. This fixes that so it does not re-enable the option. refs bitcoin-core#151
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, I aim to fix #151.
As @Rspigler noted in the issue:
Point number one is still an issue. However, as @vasild mentioned here, point number 2 is no longer happening as of 17072f7. They point out another inconsistency where:
This PR fixes @Rspigler's point number one by changing the "Encrypt Wallet" tooltip to clarify that it encrypts the private key rather than the wallet. It also fixes @vasild's noted inconsistency where the checkbox becomes re-enabled.
Rationale
I considered for a moment that it might be more technically accurately to say "encrypt private key" instead of "encrypt wallet". However, I counted 27 instances of user-facing strings that describe encrypting the wallet. Users might be accustomed to the feature being called "encrypt wallet", so changing the text all across the app felt drastic, IMHO. Therefore, I thought we could simply provide some clarification in the tooltip that encrypting the wallet specifically means encrypting the private keys, but not other wallet metadata.
Testing
I successfully built the application with each commit of this PR, and I ran
ctest --test-dir buildto verify all the tests passed.First PR
This is my first time opening a PR to Bitcoin Core. I've done my research on best practices, but I probably made errors. Happy to correct anything I may have missed.