Fix empty exception values from bad ThrowFn declaration#33
Merged
ryanofsky merged 1 commit intobitcoin-core:masterfrom Mar 22, 2020
Merged
Fix empty exception values from bad ThrowFn declaration#33ryanofsky merged 1 commit intobitcoin-core:masterfrom
ryanofsky merged 1 commit intobitcoin-core:masterfrom
Conversation
Also extend libmultiprocess unit test with coverage for this case. Bad non-const ThrowFn declaration was causing ReadDestEmplace to try read exception values after throwing them instead of before (in update_fn(construct()) expression when construct() callback throws). This was causing bitcoin functional tests to fail because JSONRPCError exceptions caught were just null UniValue objects instead of objects with code and message fields set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also extend libmultiprocess unit test with coverage for this case.
Bad non-const ThrowFn declaration was causing ReadDestEmplace to try read
exception values after throwing them instead of before (in
update_fn(construct()) expression when construct() callback throws).
This was causing bitcoin functional tests to fail because JSONRPCError
exceptions caught were just null UniValue objects instead of objects with code
and message fields set.