Move test/src/ files one level up#48
Merged
ryanofsky merged 1 commit intobitcoin-core:masterfrom Mar 15, 2021
Merged
Conversation
This will make test/ directory structure consistent with example/. I want the example structure to be as simple as possible, and there's no need for tests or examples to have separate include and src subdirectories when unlike the main libmultiprocess library, they aren't installing system headers to /usr/include and don't need a distinction between internal source files and external header files. Get rid of BUILD_INTERFACE filtered expressions in mptest include directories for the same reason. mptest isn't an installed library so it has no need for different BUILD_INTERFACE and INSTALL_INTERFACE include paths https://cmake.org/cmake/help/latest/command/target_include_directories.html.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will make
test/directory structure consistent with newexample/directory. I want the example structure to be as simple as possible, and there's no need for tests or examples to have separateinclude/andsrc/subdirectories when they aren't installing public headers to/usr/include.Also get rid of
BUILD_INTERFACEcmake expressions inmptesttarget include directory list for the same reason.mptestisn't an installed library so it has no need for differentiatedBUILD_INTERFACEandINSTALL_INTERFACEinclude lists (https://cmake.org/cmake/help/latest/command/target_include_directories.html).