Fix std::move compiler warning#58
Merged
ryanofsky merged 1 commit intobitcoin-core:masterfrom Oct 25, 2021
Merged
Conversation
Collaborator
ryanofsky
commented
Oct 25, 2021
ryanofsky
commented
include/mp/proxy-io.h: In member function ‘mp::Logger mp::EventLoop::log()’:
include/mp/proxy-io.h:160:25: error: moving a local object in a return statement prevents copy elision [-Werror=pessimizing-move]
160 | return std::move(logger);
| ~~~~~~~~~^~~~~~~~
include/mp/proxy-io.h:160:25: note: remove ‘std::move’ call
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Dec 17, 2021
Fix std::move error bitcoin-core/libmultiprocess#58
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Dec 22, 2021
Fix std::move error bitcoin-core/libmultiprocess#58
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Dec 31, 2021
Fix std::move error bitcoin-core/libmultiprocess#58
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Dec 31, 2021
Fix std::move error bitcoin-core/libmultiprocess#58
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jan 3, 2022
Fix std::move error bitcoin-core/libmultiprocess#58
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jan 3, 2022
Fix std::move error bitcoin-core/libmultiprocess#58
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jan 7, 2022
Fix std::move error bitcoin-core/libmultiprocess#58
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jan 7, 2022
Fix std::move error bitcoin-core/libmultiprocess#58
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jan 13, 2022
Fix std::move error bitcoin-core/libmultiprocess#58
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jan 13, 2022
Fix std::move error bitcoin-core/libmultiprocess#58
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Aug 24, 2022
Fix std::move error bitcoin-core/libmultiprocess#58
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Aug 24, 2022
Fix std::move error bitcoin-core/libmultiprocess#58
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Sep 8, 2022
Fix std::move error bitcoin-core/libmultiprocess#58
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Sep 8, 2022
Fix std::move error bitcoin-core/libmultiprocess#58
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Sep 26, 2022
Fix std::move error bitcoin-core/libmultiprocess#58
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Sep 26, 2022
Fix std::move error bitcoin-core/libmultiprocess#58
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jan 20, 2023
Fix std::move error bitcoin-core/libmultiprocess#58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.