Fix clang "unknown warning group" errors#65
Merged
ryanofsky merged 1 commit intobitcoin-core:masterfrom Jan 3, 2022
Merged
Conversation
Use clang __has_warning macro to avoid "unknown warning group '-Wsuggest-override'" warning in older versions of clang that have the __has_warning macro but don't have the suggest-override warning. Errors were showing up in https://github.com/bitcoin/bitcoin/pull/10102/checks?check_run_id=4671391974 https://cirrus-ci.com/task/4642955743985664
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use clang __has_warning macro to avoid
unknown warning group '-Wsuggest-override'warning in older versions of clang that have the__has_warningmacro but don't have thesuggest-overridewarning.Errors were showing up https://github.com/bitcoin/bitcoin/pull/10102/checks?check_run_id=4671391974 / https://cirrus-ci.com/task/4642955743985664