Use defined CXX_STANDARD for environment introspection#71
Merged
ryanofsky merged 1 commit intobitcoin-core:masterfrom Aug 31, 2022
Merged
Use defined CXX_STANDARD for environment introspection#71ryanofsky merged 1 commit intobitcoin-core:masterfrom
CXX_STANDARD for environment introspection#71ryanofsky merged 1 commit intobitcoin-core:masterfrom
Conversation
ryanofsky
approved these changes
Aug 31, 2022
Collaborator
ryanofsky
left a comment
ryanofsky
left a comment
There was a problem hiding this comment.
Code review ACK 2eff5da. The original reason this was implemented this way was that some versions of capnproto required c++14 while bitcoin was still using c++11, so there really was a mix of versions being used together. But it is simpler to set a default version now, and good to use the same version for checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It doesn't look robust to use different C++ standards for configuration and building.
This PR, for example, will apply the
-std=gnu++17compiler option for all checks during configuration when building with GCC.