Merged
Conversation
Member
|
Paging @voisine as (one of) the authors of BIP39, can you have a look at this change? |
Contributor
|
non-spanish speaking ack. |
Contributor
|
@Y75QMO you'll also probably want to add a link to the word list here: https://github.com/bitcoin/bips/blob/master/bip-0039/bip-0039-wordlists.md |
Contributor
Author
Contributor
|
@laanwj we found an alarming high number (80+) of potentially offensive words in the spanish file, which makes the list simply unusable: https://zerobin.net/?49c8b750a5e169ec#5HlYfF26q5PJivUZRyZvGHj554Y6DYICcNO56kxqPpE= Request advice on how to fix this. Should we create a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are a some of the restrictions we have followed in order to create the Spanish wordlist:
There are more restrictions. The full set of restrictions is defined in python here: https://github.com/Y75QMO/Tests-for-BIP39-Spanish-wordlist.
We have scanned using software more than 600,000 words and manually reviewed one by one more than 40,000 words. Choosing 2,048 and following all the rules is not an easy task and more than one list is possible. Any help or review of the wordlist is appreciated.