Skip to content

Amend BIP72 by an "h" parameter, which contains a hash of the…#106

Closed
schildbach wants to merge 1 commit intobitcoin:masterfrom
schildbach:bip72-hash
Closed

Amend BIP72 by an "h" parameter, which contains a hash of the…#106
schildbach wants to merge 1 commit intobitcoin:masterfrom
schildbach:bip72-hash

Conversation

@schildbach
Copy link
Copy Markdown
Contributor

…PaymentRequest message that is fetched via the "r" parameter.

The hash is meant to link the trust anchor (e.g. the QR code) to the payment request message in a secure way. This will solve the problem several apps are comparing address+amount fields as a workaround instead, preventing some advanced BIP70 usecases. When these apps read a matching hash, they need not compare any of the other fields.

Thanks to Julian Haight for helping with the standard.

…Request message that is fetched via the "r" parameter.
@laanwj
Copy link
Copy Markdown
Member

laanwj commented Sep 12, 2014

Sounds like a good idea to me.

However various people have protested against non-trivial changes to current BIPs in the past, especially those in common use. Instead of 'amend' BIP72 it may be better to add a new BIP that describes this.

Also this needs a discussion post on the mailing list.

@schildbach
Copy link
Copy Markdown
Contributor Author

Thanks for reminding me on the discussion post. I have posted now.

@jgarzik
Copy link
Copy Markdown
Contributor

jgarzik commented Sep 12, 2014

Procedural: We don't patch deployed BIPs.

A new BIP is needed.

@laanwj
Copy link
Copy Markdown
Member

laanwj commented Sep 12, 2014

@jgarzik I had already said that.

@schildbach
Copy link
Copy Markdown
Contributor Author

@jgarzik It was never finished, so I thought its a better idea to "patch" it. But I'm ok with moving to a new BIP number as well if that makes the majority happy.

@gavinandresen
Copy link
Copy Markdown
Contributor

New BIP number.

@laanwj
Copy link
Copy Markdown
Member

laanwj commented Oct 15, 2014

How can we move this forward?

@schildbach Have you proposed this as a new BIP yet?

@AndySchroder
Copy link
Copy Markdown

A new BIP has been drafted up that includes this improvement as well as several others. As soon as @schildbach and I finish fine tuning a few sentances, it will be announced for feedback/review.

@laanwj
Copy link
Copy Markdown
Member

laanwj commented Oct 15, 2014

Thanks for letting me know @AndySchroder I'll close this issue then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants