[BIP78] Fix client implementation when there is output substitution#1171
Merged
kallewoof merged 1 commit intobitcoin:masterfrom Aug 31, 2021
Merged
[BIP78] Fix client implementation when there is output substitution#1171kallewoof merged 1 commit intobitcoin:masterfrom
kallewoof merged 1 commit intobitcoin:masterfrom
Conversation
junderw
added a commit
to bitcoinjs/payjoin-client
that referenced
this pull request
Aug 31, 2021
This was referenced Aug 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug in the payjoin client reference implementation if the receiver used output substitution, causing the payjoin to fallback to normal payment unecessarily.
Fixing bug reported by @Kixunil (btcpayserver/btcpayserver#2677)
Fixed on the C# client (btcpayserver/BTCPayServer.BIP78@451e112) and tested by Kixunil.
The bug was best explained by @Kixunil