[BIP-0119] Include test vectors for CTV in BIP's subdirectory#1260
Merged
luke-jr merged 1 commit intobitcoin:masterfrom Jan 15, 2022
Merged
[BIP-0119] Include test vectors for CTV in BIP's subdirectory#1260luke-jr merged 1 commit intobitcoin:masterfrom
luke-jr merged 1 commit intobitcoin:masterfrom
Conversation
Contributor
Author
|
cc @glozow these match the test vectors currently in the BIP; you can cross reference those in review. |
glozow
reviewed
Jan 3, 2022
Member
glozow
left a comment
glozow
left a comment
There was a problem hiding this comment.
utACK ae747e2 - I haven't verified that all the tests match the spec or how well it covers all permutations of scripts, but thanks for adding test vectors. Assuming the coverage is good, to a maintainer of a client that isn't Bitcoin Core, I imagine this would be much more helpful than trying to match the reference implementation.
| https://github.com/JeremyRubin/bitcoin/tree/checktemplateverify. | ||
|
|
||
| Test vectors are available in [/bip-0119/vectors the bip-0119/vectors | ||
| directory] for checking compatibility with the refrence implementation and BIP. |
Member
There was a problem hiding this comment.
Suggested change
| directory] for checking compatibility with the refrence implementation and BIP. | |
| directory] for checking compatibility with the reference implementation and BIP. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds test vector files for those wishing to check CTV behavior matches Bitcoin Core / the BIP.