Skip to content

[BIP-119] Slim down motivation, add more references#1320

Merged
luke-jr merged 4 commits intobitcoin:masterfrom
JeremyRubin:delete-motivations-119
Jul 25, 2022
Merged

[BIP-119] Slim down motivation, add more references#1320
luke-jr merged 4 commits intobitcoin:masterfrom
JeremyRubin:delete-motivations-119

Conversation

@JeremyRubin
Copy link
Copy Markdown
Contributor

The level of detail in the motivations for BIP-119 was excessive, this PR removes the lengthy motivation section and adds more links out to various resources.

Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK de0ff36

This would make it easier for developers to review the BIP and not get confused with the use cases. 2 suggestions that can be ignored.

Copy link
Copy Markdown

@bucko13 bucko13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Just a couple of small copy edit nits.

@AdamISZ
Copy link
Copy Markdown
Contributor

AdamISZ commented May 22, 2022

ACK for this simplification, the very large detailing of application constructs seemed not appropriate for this type of doc.

Having said that, it may be overkill to give only names and leave everything else to citations; short summaries in-text of a few major applications are common (off the top of my head I remember BIP65, BIP340, I'm sure there are many, many others!). But I mean, this works, as is.

(Another thing to consider is ordering: I never liked having to scroll so far down to find the Rationale section).

@JeremyRubin JeremyRubin force-pushed the delete-motivations-119 branch from 339a43b to cde2bd3 Compare May 23, 2022 16:47
@JeremyRubin
Copy link
Copy Markdown
Contributor Author

@AdamISZ I think the BIP-65 example makes me think that it may be best to err on the lighter side w.r.t. applications...

None of the given examples are particularly in common use, if at all? Where they have been used is in HTLCs, which are (IMO -- I could be misreading) very different from what is stated in the BIP.

Similarly, BIP-340 links to MuSig, which has a flaw rendering it "less usable"/unprovable.

This leads me to believe that it's better to be abstract in the applications section, as previous examples in BIPs don't fully stand the test of time, but the concepts do.

@AdamISZ
Copy link
Copy Markdown
Contributor

AdamISZ commented Jun 2, 2022

I think that's a pretty decent overall take fwiw.

(Re: BIP340's link to the 2018/068 paper, it's no longer the flawed version there, but the patched up one, so it's not technically a mistake, but yeah for sure once the MuSig2 BIP is actually assigned they will presumably want to update it since that's significantly preferable).

@luke-jr luke-jr merged commit d1b1ec4 into bitcoin:master Jul 25, 2022
@luke-jr
Copy link
Copy Markdown
Member

luke-jr commented Jul 25, 2022

IMO better to keep it all in the BIP (links die), but you're the author...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants