BIP341: add aux_rand argument to taproot_sign_key#1379
Merged
kallewoof merged 1 commit intobitcoin:masterfrom Jan 4, 2023
Merged
BIP341: add aux_rand argument to taproot_sign_key#1379kallewoof merged 1 commit intobitcoin:masterfrom
kallewoof merged 1 commit intobitcoin:masterfrom
Conversation
jonasnick
reviewed
Oct 24, 2022
DariusParvin
force-pushed
the
bip341-aux_rand
branch
from
8fde2cd to
e24f685
Compare
jonasnick
approved these changes
Nov 4, 2022
Contributor
jonasnick
left a comment
jonasnick
left a comment
There was a problem hiding this comment.
ACK e24f685
Thanks @DariusParvin !
Member
|
ACK e24f685 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
schnorr_signfunction from the bip340 reference code has a third required argumentaux_rand: bytes.Change:
addingaux_randas an optional argument that defaults to0x0000...bip340_aux_randas a required argument to the functiontaproot_sign_key