PSBTv0: Update Simple Signer Algorithm for SegWitv0 inputs#1430
Merged
kallewoof merged 1 commit intobitcoin:masterfrom Mar 8, 2023
Merged
PSBTv0: Update Simple Signer Algorithm for SegWitv0 inputs#1430kallewoof merged 1 commit intobitcoin:masterfrom
kallewoof merged 1 commit intobitcoin:masterfrom
Conversation
It is no longer expected that SegWitV0 inputs have no witness-utxo field. Reverting the order of checks avoids this assumption (while still relying on the mandatory lack of witness-utxo for legacy inputs).
bigspider
changed the title
Member
|
ACK e538fa8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Simple Signer Algorithm is not updated to the fact that SegWitv0 inputs are now typically expected to have both the non-witness-utxo and the witness-utxo field (instead of the ealier requirement of omitting the non-witness-utxo).
By reverting the order of the checks, it is at least semantically correct.
Possible TODOs for followups: