Skip to content

Update bip45 based on comments by dskloet#149

Merged
laanwj merged 1 commit intobitcoin:masterfrom
maraoz:patch-2
Jun 22, 2015
Merged

Update bip45 based on comments by dskloet#149
laanwj merged 1 commit intobitcoin:masterfrom
maraoz:patch-2

Conversation

@maraoz
Copy link
Copy Markdown
Contributor

@maraoz maraoz commented Apr 13, 2015

  • fix examples
  • fix address discovery section
  • fix purpose to 45
  • mention difference with bip-0044

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above you replaced $purpose with 45'. Do you want to do that here as well?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, will fix

@laanwj
Copy link
Copy Markdown
Member

laanwj commented May 26, 2015

Let me know when this is ready for merging

- fix examples
- fix address discovery section
- fix purpose to 45
- mention difference with bip-0044
@maraoz
Copy link
Copy Markdown
Contributor Author

maraoz commented May 26, 2015

Addressed all comments by @dskloet. When he ACKs, we can merge. Thanks @laanwj 👍

@dskloet
Copy link
Copy Markdown

dskloet commented May 26, 2015

LGTM

laanwj added a commit that referenced this pull request Jun 22, 2015
Update bip45 based on comments by dskloet
@laanwj laanwj merged commit d457fa2 into bitcoin:master Jun 22, 2015
@maraoz maraoz deleted the patch-2 branch June 22, 2015 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants