Add missing SIGHASH flag to BIP 143 Example#1545
Closed
davidgumberg wants to merge 1 commit intobitcoin:masterfrom
Closed
Add missing SIGHASH flag to BIP 143 Example#1545davidgumberg wants to merge 1 commit intobitcoin:masterfrom
davidgumberg wants to merge 1 commit intobitcoin:masterfrom
Conversation
The first example ('Native P2WPKH') signature in BIP 143 was missing
a SIGHASH flag. The signature scheme requires a DER encoded signature
with a one-byte SIGHASH/'hash type' flag appended. (Excepting schnorr
signatures which can omit a flag to implicitly signal SIGHASH_DEFAULT)
|
ACK, since all other examples have the sighash flag appended in the signature. Either this or include a new field "sighash flag" and exclude the sighash flag from all other signature examples |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Member
|
Duplicate of #748 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first example (Native P2WPKH) signature in BIP 143 was missing a SIGHASH flag. The signature scheme requires a DER encoded signature with a one-byte SIGHASH/'hash type' flag appended. (Excepting schnorr signatures which can omit a flag to implicitly signal
SIGHASH_DEFAULT)This pull request corrects the example to include the
0x01/SIGHASH_ALLflag.