BIP105: Update to account for BIP34#194
Merged
luke-jr merged 1 commit intobitcoin:masterfrom Sep 19, 2015
Merged
Conversation
Member
There was a problem hiding this comment.
Probably should stick to bytes here to be clear the 2 MB value is signed LE? And you need 4 bytes for this to account for the sign.
btcdrak
force-pushed
the
patch-2
branch
3 times, most recently
from
0d1fb66 to
1f56123
Compare
luke-jr
added a commit
that referenced
this pull request
Sep 19, 2015
BIP105: Update to account for BIP34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The voting mechanism did not previously account for BIP34.