BIP-0014: MAX_SUBVERSION_LENGTH#196
Closed
maflcko wants to merge 1 commit intobitcoin:masterfrom
maflcko:patch-1
Closed
BIP-0014: MAX_SUBVERSION_LENGTH#196maflcko wants to merge 1 commit intobitcoin:masterfrom maflcko:patch-1
maflcko wants to merge 1 commit intobitcoin:masterfrom
maflcko:patch-1
Conversation
Member
|
This shouldn't cause a fork of the network... |
Member
Author
|
Imagine I released bitcoin-xxl with twice the |
Member
|
Your XXL node will talk to old/non-spammy XXL nodes which will talk to Core nodes, so no big deal. |
MAX_SUBVERSION_LENGTH = 256
Member
Author
|
Maybe it's better to just "recommend" the implementation bitcoin-core does/did and link to the PRs... Also, ping @luke-jr Could you please enable the GitHub issue tracker for this repo? |
Member
|
@MarcoFalke Discussion of BIPs should be on the bitcoin-dev mailing list, not GitHub. @genjix @phantomcircuit May I close this unmerged? |
|
@luke-jr yes |
real-or-random
pushed a commit
to real-or-random/bips
that referenced
this pull request
Mar 12, 2020
Update reference code and test vectors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if this should be mentioned in the bip because it may change at some point in the future... Yet, changing it may cause a fork of the network (extremely unlikely but possible).