Fix broken anchor links in BIP 0342, BIP 0022, BIP 0023 #2091
+14
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point github changed how anchor links work. Currently anchor links using the double square bracket format require that the anchor be prepended with
user-content-.This means that the following link used to work, but doesn't today
The link that works today would be
The link still resolves to the page, but just not the anchor so I suspect no one noticed.
In addition to this it appears that in the past github anchors could have spaces or punction, but that is no longer valid. Spaces are replaced with
_and punction appears to be not included in the anchor.I fixed this for BIP 0342, BIP 0022, BIP 0023, but it impacts a good chunk of BIPs. If you want I can change this PR to fix for all the BIPs, but I didn't want to put in the time to do that in case an editor wanted to make these changes themselves.
If this PR isn't useful or the project isn't interested in fixing this very minor linking issue. Feel free to close this PR.