BIP-78: fix reference sender implementation pseudocode#2096
Closed
VolodymyrBg wants to merge 1 commit intobitcoin:masterfrom
Closed
BIP-78: fix reference sender implementation pseudocode#2096VolodymyrBg wants to merge 1 commit intobitcoin:masterfrom
VolodymyrBg wants to merge 1 commit intobitcoin:masterfrom
Conversation
Member
|
Given your profile, I assume that you are not actually implementing BIP 78, but that you rather pointed an LLM at a random file in this repository to farm a commit. If an LLM can trivially fix this pseudocode, it’s also not an impediment to actual implementers. Please stop creating busywork for us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reference sender pseudocode diverged from the canonical BTCPayServer implementation and contained undefined variables, missing fee rate initialization, and an incorrect upper bound on the additional fee contribution, which could mislead implementers copying it as-is.
https://github.com/btcpayserver/BTCPayServer.BIP78/blob/master/BIP78.Sender/PayjoinClient.cs