BIP-352: warn against stopping scan due to wallet policy filtering#2134
Merged
murchandamus merged 1 commit intobitcoin:masterfrom Apr 7, 2026
Merged
BIP-352: warn against stopping scan due to wallet policy filtering#2134murchandamus merged 1 commit intobitcoin:masterfrom
murchandamus merged 1 commit intobitcoin:masterfrom
Conversation
Adds a warning to the "if no matches are found, stop" scanning step. Without it, wallet developers may be tempted to apply policy filtering (e.g. dust) before deciding to continue, causing subsequent outputs for the same sender to be missed.
Contributor
Author
|
cc: @theStack |
murchandamus
added
Proposed BIP modification
Pending acceptance
murchandamus
reviewed
Apr 7, 2026
Member
murchandamus
left a comment
murchandamus
left a comment
There was a problem hiding this comment.
LGTM, waiting for @theStack to review, though.
Contributor
|
lgtm ACK df87830 Thanks! |
murchandamus
removed
the
Pending acceptance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the discussion in #2106 (comment), this PR adds a warning to the "if no matches are found, stop" scanning step. Without it, wallet developers may be tempted to apply policy filtering (e.g. dust) before deciding to continue, causing subsequent outputs for the same sender to be missed.