BIP-434: Various rationale edits#2181
Merged
Merged
Conversation
jonatack
added
the
BIP Update by Owner
jonatack
reviewed
May 29, 2026
|
|
||
| For features published as a BIP, the `featureid` SHOULD be the assigned | ||
| BIP number, eg "BIP434", or be based on the BIP number (eg, "BIP434v2" | ||
| where the "v2" suffix covers versioning, or "BIP434.3" where the ".3" |
Member
There was a problem hiding this comment.
Maybe use a semantic versioning style in the version example, since activation of BIP3.
Contributor
Author
There was a problem hiding this comment.
semver style is:
MAJOR version when you make incompatible API changes MINOR version when you add functionality in a backward compatible manner PATCH version when you make backward compatible bug fixes
The featureid should only be updated for incompatible API changes -- if your change is compatible, you keep advertising the same featureid so you can operate unchanged with older peers. So only including a single MAJOR version number ("2" here) seems already a match for semver to me.
darosior
approved these changes
May 29, 2026
Member
darosior
left a comment
darosior
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for adding the rationale about minimum size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.