Skip to content

Recommend including intermediate certificates in a BIP70 payment request.#22

Merged
gmaxwell merged 1 commit intobitcoin:masterfrom
schildbach:bip70-recommend-intermediate-certs
Apr 25, 2014
Merged

Recommend including intermediate certificates in a BIP70 payment request.#22
gmaxwell merged 1 commit intobitcoin:masterfrom
schildbach:bip70-recommend-intermediate-certs

Conversation

@schildbach
Copy link
Copy Markdown
Contributor

No description provided.

@gavinandresen
Copy link
Copy Markdown
Contributor

I think the wording needs to express the idea that the certificate chain MUST be complete, up to (but not including) a trusted root certificate. But RFC5280 validation will fail if it is not, so I'm not sure how explicit we really need to be.

@ExperimentsAndIdeas
Copy link
Copy Markdown

The AIA field should tell the client where to fetch the issuer certificate if it's not included. We should recommend that the certificate is always available of HTTP and perhaps Namecoin (or other store).

It may be educational to say that HTTPS storage of a signed parent certificate provides no security value add.

(new to GitHub, not sure if this is where this comment should go. Please advise on the correct location to discuss this)

@schildbach
Copy link
Copy Markdown
Contributor Author

@makerofthings7 Keep in mind wallets might not have HTTP(S) access, maybe not even TCP connectivity. IMHO it should be a goal of this spec that the cert chain can always be validated offline.

@ExperimentsAndIdeas
Copy link
Copy Markdown

If offline validation is a goal, and we want to support DANE (self published CA roots in DNS) then the entire chain, including the root should be included.

http://tools.ietf.org/html/rfc6698

@schildbach @gavinandresen

@schildbach
Copy link
Copy Markdown
Contributor Author

I changed the wording to:

"This MUST be
followed by additional certificates, with each subsequent certificate
being the one used to certify the previous one, up to (but not
including) a trusted root authority. The trusted root authority MAY be
included."

That allows self-signed CA roots while still suggesting that normally the root cert is not required.

@gavinandresen
Copy link
Copy Markdown
Contributor

ACK

@schildbach
Copy link
Copy Markdown
Contributor Author

@makerofthings7 Are you ok with the current change?

@ExperimentsAndIdeas
Copy link
Copy Markdown

Yes thank you.

@schildbach
Copy link
Copy Markdown
Contributor Author

Ping. What's needed to get this merged? (I just rebased on current master)

@schildbach
Copy link
Copy Markdown
Contributor Author

Ping! What's needed to get this merged?

gmaxwell added a commit that referenced this pull request Apr 25, 2014
…erts

Recommend including intermediate certificates in a BIP70 payment request.
@gmaxwell gmaxwell merged commit cd2850f into bitcoin:master Apr 25, 2014
@schildbach schildbach deleted the bip70-recommend-intermediate-certs branch May 14, 2014 11:25
luke-jr pushed a commit to luke-jr/bips that referenced this pull request Jun 6, 2017
guggero pushed a commit to guggero/bips that referenced this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants