Skip to content

BIP141: Add 520 bytes witness stack limit#303

Merged
luke-jr merged 1 commit intobitcoin:masterfrom
jl2012:patch-10
Jan 29, 2016
Merged

BIP141: Add 520 bytes witness stack limit#303
luke-jr merged 1 commit intobitcoin:masterfrom
jl2012:patch-10

Conversation

@jl2012
Copy link
Copy Markdown
Contributor

@jl2012 jl2012 commented Jan 26, 2016

@luke-jr
Copy link
Copy Markdown
Member

luke-jr commented Jan 26, 2016

??? Why a limit?

@sipa
Copy link
Copy Markdown
Member

sipa commented Jan 26, 2016 via email

@luke-jr
Copy link
Copy Markdown
Member

luke-jr commented Jan 26, 2016

The script itself should be longer than 520 bytes or we get the P2SH regression again...

@sipa
Copy link
Copy Markdown
Member

sipa commented Jan 26, 2016 via email

@jl2012
Copy link
Copy Markdown
Contributor Author

jl2012 commented Jan 26, 2016

@luke-jr @sipa The script limit for P2WSH is 10000 bytes, right?

@luke-jr
Copy link
Copy Markdown
Member

luke-jr commented Jan 26, 2016

@sipa This is unclear, as the witnessScript is popped off the witness stack...

Comment thread bip-0141.mediawiki
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luke-jr re: witnessScript size and witness stack size

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say "witness redeem" instead of witnessScript.
WitnessScript are the pushes for a particular input.

@jl2012
Copy link
Copy Markdown
Contributor Author

jl2012 commented Jan 26, 2016

Testing with witnessScript of 10000 and 10001 bytes:
https://www.irccloud.com/pastebin/xAEd96Yk/
https://www.irccloud.com/pastebin/k6yfZjTa/

@andre-amorim
Copy link
Copy Markdown

@jl2012 From left to right top to bottom coordinates of meaning.. is the first link to 10000 and the 10001 to 2nd link ?

@jl2012
Copy link
Copy Markdown
Contributor Author

jl2012 commented Jan 26, 2016

@andre-amorim yes, you can find it by clicking the links

@andre-amorim
Copy link
Copy Markdown

Thanks @jl2012 it's 212k on my lp0, yep I printed it out.

luke-jr added a commit that referenced this pull request Jan 29, 2016
BIP141: Add 520 bytes witness stack limit
@luke-jr luke-jr merged commit e7f28d8 into bitcoin:master Jan 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants